8244735: Error on iOS passing keys with unicode values greater than 255

[jperedadnr]

With this PR, we pass directly the 16-bit unsigned short for a character (unicode value) to the Java layer, avoiding the cast with the C++ 8-bit char, that fails for non-ascii characters like euro (€) or quote (").

We also avoid the mapping between iOS keys and JavaFX KeyCode, except for ENTER and BACK_SPACE, as the mapping for some keys was wrong, like for "%", with ascii value 0x25, that was mapped to KeyCode.LEFT.

Finally, the iOS keyboard is set to UIKeyboardTypeASCIICapable, to prevent the display of the emoji keyboard, that can't be currently processed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8244735: Error on iOS passing keys with unicode values greater than 255

Reviewers

• Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/217/head:pull/217
$ git checkout pull/217

[bridgekeeper]

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (31b8bea)

[johanvos]

This indeed fixes JDK-8244735.
It only touches ios-specific files, hence there is no impact on other platforms.

[openjdk]

@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244735: Error on iOS passing keys with unicode values greater than 255

Reviewed-by: jvos

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

• b0d66d0: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
• 0f87d20: 8244487: One Windows 10 SDK file missing from FX build

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b0d66d0ded97d1a6514729dac73bc127868326da.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jperedadnr]

/integrate

[openjdk]

@jperedadnr
Your change (at version 31b8bea) is now ready to be sponsored by a Committer.

[johanvos]

/sponsor

[openjdk]

@johanvos @jperedadnr The following commits have been pushed to master since your change was applied:

• b0d66d0: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
• 0f87d20: 8244487: One Windows 10 SDK file missing from FX build

Your commit was automatically rebased without conflicts.

Pushed as commit b14e085.