Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8181775: JavaFX WebView does not calculate border-radius properly #218

Closed
wants to merge 4 commits into from

Conversation

@bhaweshkc
Copy link
Collaborator

@bhaweshkc bhaweshkc commented May 14, 2020

root cause of issue is prism's fillRoundedRect() API doesn't allow rendering of rounded corner rectangle if four corners have different radii. but same can be achieved via Path. to fix the issue, in GraphicsContextJava.cpp while rendering fillRoundedRect, check if all four corners have same radii. if yes, use FILL_ROUNDED_RECT to draw it otherwise construct a path from given rounded rect and draw it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8181775: JavaFX WebView does not calculate border-radius properly

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Arun Joseph (ajoseph - Committer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/218/head:pull/218
$ git checkout pull/218

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 14, 2020

👋 Welcome back bhaweshkc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 14, 2020

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 15, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented May 15, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth kevinrushforth self-requested a review May 15, 2020
@kevinrushforth kevinrushforth removed their assignment May 15, 2020
Copy link
Member

@kevinrushforth kevinrushforth left a comment

The fix looks correct, but I want to test it. I left one minor comment on the test.

@kevinrushforth kevinrushforth self-requested a review May 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2020

@bhaweshkc this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8181775
git fetch https://git.openjdk.java.net/jfx master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the merge-conflict label Jul 23, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 23, 2020

In general, we recommend not to rebase your branch once you have opened the PR. Occasionally there might be a need, but the usual way to do it is to merge in the latest upstream master branch without rebasing.

@kevinrushforth kevinrushforth requested a review from arun-Joseph Aug 7, 2020
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I confirm that the test passes with the fix and fails without the fix.

Copy link
Member

@arun-Joseph arun-Joseph left a comment

The fix and test looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2020

@bhaweshkc This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8181775: JavaFX WebView does not calculate border-radius properly

Reviewed-by: kcr, ajoseph
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch:

  • af000b2: Merge
  • 5d34d72: 8245053: Keyboard doesn't show when TextInputControl has focus
  • 487854c: 8246343: Fix mistakes in FX API docs
  • fc38ce6: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors
  • a46b250: Merge
  • 926b5b6: 8249839: Cherry pick GTK WebKit 2.28.3 changes
  • 6b00892: 8250238: Media fails to load libav 58 library when using modules from maven central

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate af000b285a328f89258a699292e2ea245cf73cf6.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arun-Joseph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 10, 2020
@bhaweshkc
Copy link
Collaborator Author

@bhaweshkc bhaweshkc commented Aug 10, 2020

/integrate

@openjdk openjdk bot added the sponsor label Aug 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2020

@bhaweshkc
Your change (at version f9ade01) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 10, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2020

@kevinrushforth @bhaweshkc The following commits have been pushed to master since your change was applied:

  • 5c596b1: 8196079: Remove obsolete Pisces rasterizer
  • af000b2: Merge
  • 5d34d72: 8245053: Keyboard doesn't show when TextInputControl has focus
  • 487854c: 8246343: Fix mistakes in FX API docs
  • fc38ce6: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors
  • a46b250: Merge
  • 926b5b6: 8249839: Cherry pick GTK WebKit 2.28.3 changes
  • 6b00892: 8250238: Media fails to load libav 58 library when using modules from maven central

Your commit was automatically rebased without conflicts.

Pushed as commit f216c5f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants