Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240969: WebView does not allow to load style sheet in modularized applications #22

Closed
wants to merge 4 commits into from

Conversation

@tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Oct 24, 2019

Currently, loading a style sheet file using WebView.getEngine().setUserStyleSheetLocation(url) fails if the url start's with jrt, i.e. if the file is packaged in an application image using jlink. This is fixed with this PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240969: WebView does not allow to load style sheet in modularized applications

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Arun Joseph (ajoseph - Committer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/22/head:pull/22
$ git checkout pull/22

Currently, loading a style sheet file using `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url start's with `jrt`, i.e. if the file is packaged in an application image using jlink. This is fixed with this PR.
@bridgekeeper bridgekeeper bot added the oca label Oct 24, 2019
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 24, 2019

Hi tobiasdiez, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tobiasdiez" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@Siedlerchr Siedlerchr mentioned this pull request Oct 25, 2019
0 of 6 tasks complete
@johanvos
Copy link
Collaborator

@johanvos johanvos commented Oct 29, 2019

Hi Tobias,
A PR needs to refer a bug in JBS. (see https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md)
Do you have an account in JBS? If not, I can file one for you.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 7, 2019

@tobiasdiez are you still interested in pursuing this fix?

@tobiasdiez
Copy link
Contributor Author

@tobiasdiez tobiasdiez commented Nov 7, 2019

Yes, I am. But, to be honest, it's a bit overly complicated to contribute here with the JBS bug requirement and the oracle agreement. Hopefully I'll find the time to do this next week.

@ageofadz ageofadz mentioned this pull request Nov 20, 2019
3 of 4 tasks complete
@tobiasdiez
Copy link
Contributor Author

@tobiasdiez tobiasdiez commented Dec 20, 2019

/signed

The OCA should be ok now. Is there something else that needs to be done?

@bridgekeeper bridgekeeper bot added the oca-verify label Dec 20, 2019
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 20, 2019

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Dec 20, 2019

Once your GitHub account is linked to your OCA, the bot will remove the oca* labels.

The other thing that is needed is a bug report in JBS. You can file one at bugreport.java.com. This should include a test program, ideally one that you can turn into an automated unit test.

@bridgekeeper bridgekeeper bot removed oca oca-verify labels Jan 8, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 13, 2020

@tobiasdiez Your OCA has now been processed and linked with your GitHub account. This can proceed once we have a bug filed in JBS with a test case.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 12, 2020

@tobiasdiez in case you missed the earlier comment, this is now ready for you to proceed. All we need is a bug report with a test case. You can file the bug at bugreport.java.com.

@HGuillemet
Copy link

@HGuillemet HGuillemet commented Feb 25, 2020

Has this bug been finally reported ? I can do it if it didn't.
I'm having the same problem than Tobias.

@tobiasdiez
Copy link
Contributor Author

@tobiasdiez tobiasdiez commented Mar 11, 2020

Sorry for the delay, but I've finally managed to create the required bug report (internal review ID : 9063979)

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 12, 2020

This has now been transferred to the JDK project as JDK-8240969. You can update the title of this PR to include the bug ID, followed by a :, then a space, then the exact title from the bug you are fixing. So:

8240969: WebView does not allow to load style sheet in modularized applications

I note that we still need a test program that fails currently, and passes with your patch.

@tobiasdiez tobiasdiez changed the title WebView: Allow to load style sheet from jlink images 8240969: WebView does not allow to load style sheet in modularized applications Mar 13, 2020
@openjdk openjdk bot added the rfr label Mar 13, 2020
@tobiasdiez
Copy link
Contributor Author

@tobiasdiez tobiasdiez commented Mar 13, 2020

I've changed the title accordingly. However, I've no idea how to add a test and couldn't find any unit test concerning UserStyleSheetLocation (apart from some tests that make sure it was invoked on the Javafx thread).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 13, 2020

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 13, 2020

You must have some use case that fails without this proposed fix (else why are you proposing it), right?

@tobiasdiez
Copy link
Contributor Author

@tobiasdiez tobiasdiez commented Mar 13, 2020

Yes, we had this exception in our application which was (temporarily) fixed with JabRef/jabref#5497. But JabRef is 100k lines of code, so I doubt this counts as a unit test.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 13, 2020

In that case, we will need you to distill it down to a simple, standalone test program. It seems that it might not be suitable for a unit test, but we need some test to show that the fix is failing now, and works after your proposed fix.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 14, 2020

@tobiasdiez are you planning to pursue this? The review is pending a simple test case.

@tobiasdiez
Copy link
Contributor Author

@tobiasdiez tobiasdiez commented Apr 14, 2020

@kevinrushforth I've now added a test. Hope it's ok like this.

@openjdk openjdk bot removed the rfr label Apr 14, 2020
@kevinrushforth kevinrushforth self-requested a review Jul 23, 2020
@openjdk openjdk bot added the rfr label Aug 2, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 13, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Given the simplicity of the fix, I think the minimal test is enough.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 14, 2020

@arun-Joseph can you also review?

@kevinrushforth kevinrushforth requested a review from arun-Joseph Aug 14, 2020
Copy link
Member

@arun-Joseph arun-Joseph left a comment

The fix and test looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2020

@tobiasdiez This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8240969: WebView does not allow to load style sheet in modularized applications

Reviewed-by: kcr, ajoseph
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 276 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1c54e612b01547d9efed75833227ee76979d94ec.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arun-Joseph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 14, 2020
@tobiasdiez
Copy link
Contributor Author

@tobiasdiez tobiasdiez commented Aug 14, 2020

/integrate

@openjdk openjdk bot added the sponsor label Aug 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2020

@tobiasdiez
Your change (at version ad72fd6) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 14, 2020

/sponsor

@openjdk openjdk bot closed this Aug 14, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Aug 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2020

@kevinrushforth @tobiasdiez The following commits have been pushed to master since your change was applied:

  • 1c54e61: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.
  • f50d218: Merge
  • 208d828: 8228570: Add various documentation clarifications
  • 7a8708b: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors
  • aefed81: 8249777: build.gradle: project.version should not contain time stamps
  • f216c5f: 8181775: JavaFX WebView does not calculate border-radius properly
  • 5c596b1: 8196079: Remove obsolete Pisces rasterizer
  • af000b2: Merge
  • 5d34d72: 8245053: Keyboard doesn't show when TextInputControl has focus
  • 487854c: 8246343: Fix mistakes in FX API docs
  • fc38ce6: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors
  • a46b250: Merge
  • 926b5b6: 8249839: Cherry pick GTK WebKit 2.28.3 changes
  • 6b00892: 8250238: Media fails to load libav 58 library when using modules from maven central
  • aae8b6b: Merge
  • 3cc29e3: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175%
  • 5f60ea5: 8248381: Create a daemon thread for MonocleTimer
  • 9260fd1: Merge
  • f056d24: 8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins
  • 5e7e452: 8245284: Update to 610.1 version of WebKit
  • 2f4666a: 8248490: [macOS] Undecorated stage does not minimize
  • 281f5c2: Merge
  • 5de99be: Merge
  • 946590e: 8248365: Debug build crashes on Windows when playing media file
  • e2d1c02: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException
  • 82f66ca: Merge
  • d67c47f: 8201567: QuantumRenderer modifies buffer in use by JavaFX Application Thread
  • cd57bb5: Merge
  • a4f3150: 8248317: Change JavaFX release version to 16
  • 126637f: 8201570: Get two bytes for the Linux input event type, not four
  • f3a0446: 8247963: Update SQLite to version 3.32.3
  • 32584db: 8238954: Improve performance of tiled snapshot rendering
  • 869ea40: 8244212: Optionally download media and webkit libraries from latest openjfx EA build
  • 62f8cee: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo
  • 527cc2b: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine
  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts
  • 15f97ed: 8240264: iOS: Unnecessary logging on every pulse when GL context changes
  • 2ca509a: 8193800: TreeTableView selection changes on sorting
  • a5878e0: 8214699: Node.getPseudoClassStates must return the same instance on every call
  • 8440b64: 8208169: can not print selected pages of web page
  • 1727dfa: 8247163: JFXPanel throws exception on click when no Scene is set
  • 54e2507: 8247360: Add missing license file for Microsoft DirectShow Samples
  • fb962ac: 8244418: MenuBar: IOOB exception on requestFocus on empty bar
  • bf2e972: 8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars
  • b200891: 8244824: TableView : Incorrect German translation
  • f6ec5f1: Merge
  • b2b46eb: 8242892: SpinnerValueFactory has an implicit no-arg constructor
  • afa805f: 8245575: Show the ContextMenu of input controls with long press gesture on iOS
  • 5304266: 8245635: GlassPasteboard::getUTFs fails on iOS
  • ba501ef: 8246357: Allow static build of webkit library on linux
  • a02e09d: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
  • 9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux
  • 6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
  • 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
  • a78b3fb: 8242523: Update the animation and clip envelope classes
  • 1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
  • 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
  • 1663624: Merge
  • 13f42e1: Merge
  • 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
  • 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
  • 78bf7b7: 8245422: Better Pisces rasterizing
  • c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
  • 3ceee69: 8245499: Text input controls should show handles on iOS
  • 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
  • 16f446a: 8234876: Unit test classes should not extend Application
  • 2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
  • f3190db: 8244531: Tests: add support to identify recurring issues with controls et al
  • 1971c70: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest
  • 6e0b45a: 8245183: Two fxml unit tests log warnings about deprecated escape sequences
  • a13a642: 8244579: Windows "User Objects" leakage with WebView
  • 37b5edc: 8245456: MacPasteboard throws ClassCastException on static builds
  • 6e03930: 8237602: TabPane doesn't respect order of TabPane.getTabs() list
  • f8cc090: Merge
  • bb24322: 8244112: Skin implementations: must not violate contract of dispose
  • dbb6437: 8244647: Wrong first layout pass of Scrollbar controls on touch supported devices
  • 7b06190: 8242548: Wrapped labeled controls using -fx-line-spacing cut text off
  • 435671e: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
  • c14cc44: 8244417: support static build for Windows
  • b14e085: 8244735: Error on iOS passing keys with unicode values greater than 255
  • b0d66d0: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
  • 0f87d20: 8244487: One Windows 10 SDK file missing from FX build
  • 4597437: Merge
  • 4ec163d: 8242001: ChoiceBox: must update value on setting SelectionModel, part2
  • 236e2d6: 8244421: Wrong scrollbar position on touch enabled devices
  • 0385563: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi
  • 2e90076: 8242507: Add support for Visual Studio 2019
  • 39d9c3b: 8244110: NPE in MenuButtonSkinBase change listener
  • 99f7747: 8241999: ChoiceBox: incorrect toggle selected for uncontained
  • 1cae6a8: 8176499: Dependence on java.util.Timer freezes screen when OS time resets backwards
  • 2b9eb52: 8237504: Update copyright header for files modified in 2020
  • 3130fc8: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()
  • 8ad5805: 8191758: Match WebKit's font weight rendering with JavaFX
  • 66c3b38: 8227425: Add support for e-paper displays on i.MX6 devices
  • e30049f: 8242077: Add information about HTTP/2 and HttpClient usage in WebEngine
  • e0ffca3: 8242505: Some WebKit tests might fail because Microsoft libraries are not loaded
  • ceb3fce: 8087555: [ChoiceBox] uncontained value not shown
  • 818ac00: 8175358: Memory leak when moving MenuButton into another Scene
  • f1ac39b: Merge
  • 91d4c8b: 8241737: TabPaneSkin memory leak on replacing selectionModel
  • 48476eb: 8241582: Infinite animation does not start from the end when started with a negative rate
  • dedf7cb: 8242490: Upgrade to gcc 9.2 on Linux
  • 5e9fb82: 8242577: Cell selection fails on iOS most of the times
  • 69e4266: 8242489: ChoiceBox: initially toggle not sync'ed to selection
  • 1d88180: 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern
  • ec8608f: 8223298: SVG patterns are drawn wrong
  • e82046e: 8242530: [macos] Some audio files miss spectrum data when another audio file plays first
  • 7044cef: 8241476: Linux build warnings issued on gcc 9
  • bb5ce2c: Merge
  • 9d50c4c: Merge
  • 4d69a0d: 8241629: [macos10.15] Long startup delay playing media over https on Catalina
  • b1fdc45: 8242209: Increase web native thread stack size for x86 mode
  • e1cb191: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina
  • c154538: 8242106: [macos] Remove obsolete GlassView2D.m class
  • 3f663e3: 8240262: iOS refresh rate is capped to 30 Hz
  • 231879a: 8241710: NullPointerException while entering empty submenu with "arrow right"
  • 470c7d0: 8230809: HTMLEditor formatting lost when selecting all (CTRL-A)
  • fda015c: 8242167: ios keyboard handling
  • 844460b: 8242163: Android keyboard integration fails
  • 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
  • 418675a: 8236840: Memory leak when switching ButtonSkin
  • 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
  • 560ef17: 8241455: Memory leak on replacing selection/focusModel
  • d299465: Merge
  • ef37669: Merge
  • 5906521: 8241370: Crash in JPEGImageLoader after fix for JDK-8212034
  • 159f651: 8240542: Switch FX build to use JDK 14 as boot JDK
  • 6d098fe: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
  • d7f13f4: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic letter.
  • 9ecc107: 8240539: Upgrade gradle to version 6.3
  • f3a3ea0: 8234471: Canvas in webview displayed with wrong scale on Windows
  • d12e71c: 8241474: Build failing on Ubuntu 20.04
  • 2a7ab36: 8089134: [2D traversal, RTL] TraversalEngine only handles left/right key traversal correctly in RTL for top-level engine in ToolBar
  • 2aa8218: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation
  • e9c6119: 8240692: Cleanup of the javafx property objects
  • d2346b8: Merge
  • f2bca9f: Merge
  • 397587d: 8241108: Glib improvements
  • 90289a2: 8239107: Update libjpeg to version 9d
  • b81cf32: 8236259: MemoryLeak in ProgressIndicator
  • 9ea7f96: 8240832: Remove unused applecoreaudio.md third-party legal file
  • 0fc1420: Merge
  • 50e15fc: 8240466: AppJSCallback* apps launched by ModuleLauncherTest intermittently hang
  • e3026b9: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors
  • f8c235b: 8240631: Create release notes for JavaFX 14
  • cfa1193: 8236685: [macOs] Remove obsolete file dialog subclasses
  • 6900d29: Merge
  • f25e8cf: 8212034: Potential memory leaks in jpegLoader.c in error case
  • b2ac76a: 8240451: JavaFX javadoc build fails with JDK 14
  • cf0bba6: 8240211: Stack overflow on Windows 32-bit can lead to crash
  • 337ed72: 8237926: Potential memory leak of model data in javafx.scene.control.ListView
  • 960f039: 8208761: Update constant collections to use the new immutable collections
  • 10c9528: 8240265: iOS: Unnecessary logging on pinch gestures
  • 4c132cd: 8237889: Update libxml2 to version 2.9.10
  • e91bec4: Merge
  • 20328b3: 8240218: IOS Webkit implementation broken
  • 4c82af8: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…
  • 9cd6f79: 8196586: Remove use of deprecated finalize methods from javafx property objects
  • ef2f9ce: 8238755: allow to create static lib for javafx.media on linux
  • c3ee1a3: 8239822: Intermittent unit test failures in RegionCSSTest
  • 3150562: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface
  • 4eaff0d: 8239109: Update SQLite to version 3.31.1
  • 66a8f49: Merge
  • d8e7f85: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions
  • 48ddd80: Merge
  • 35a01ca: 8228867: Fix mistakes in FX API docs
  • b5e65ec: 8238434: Ensemble: Update version of Lucene to 7.7.2
  • e986459: 8227619: Potential memory leak in javafx.scene.control.ListView
  • fde42da: Merge
  • a74137a: 8236839: System menubar removed when other menubars are created or modified
  • 21d3b7e: 8237453: [TabPane] Incorrect arrow key traversal through tabs after reordering
  • e224e54: 8238526: Cherry pick GTK WebKit 2.26.3 changes
  • 6968e38: 8237469: Inherited styles don't update when node is moved
  • e21fd1f: Merge
  • 3c55a7e: Merge
  • a4b9f24: 8237503: Update copyright header for files modified in 2020
  • 1749e85: 8237975: Non-embedded Animations do not play backwards after being paused
  • aa91ebb: 8237944: webview native cl "-m32" unknown option for windows 32-bit build
  • 56267e1: 8237770: Error creating fragment phong shader on iOS
  • 2ab40c1: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)
  • 95bf2c0: 8237782: Only read advances up to the minimum of the numHorMetrics or the available font data.
  • d05e8fc: 8237833: Check glyph size before adding to glyph texture cache
  • 443c845: Merge
  • 1213ea7: Merge
  • 1823f6e: 8088198: Exception thrown from snapshot if dimensions are larger than max texture size
  • ca37c1f: 8238249: GetPrimitiveArrayCritical passed with hardcoded FALSE value
  • b96bc52: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree
  • d303a21: Merge
  • 5a0e71b: 8237372: NullPointerException in TabPaneSkin.stopDrag
  • 79fc0d0: 8232824: Removing TabPane with strong referenced content causes memory leak from weak one
  • aa6f3a4: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5
  • 921389f: Merge
  • da99e24: 8237823: Mark TextTest.testTabSize as unstable
  • 31e63de: Merge
  • 66ac99f: Merge
  • b2d8564: 8233942: Update to 609.1 version of WebKit
  • f5ee963: 8157224: isNPOTSupported check is too strict
  • 9ae37f1: 8236753: Animations do not play backwards after being stopped
  • be22e85: 8237078: [macOS] Media build broken on XCode 11
  • 14c6938: 8236798: Enhance FX scripting support
  • bfb2d0e: Merge
  • 20325e1: Merge
  • 39f6127: Merge
  • 16cea41: Merge
  • a557dd9: 8236733: Change JavaFX release version to 15
  • f907026: 8236808: javafx_iio can not be used in static environment
  • e6587ff: 8236448: Remove unused and repair broken Android/Dalvik code
  • c9519b6: 8232589: Remove CoreAudio Utility Classes
  • df8b3c5: 8233798: Ctrl-L character mistakenly removed from gstreamer.md
  • e0b45f8: 8236648: javadoc warning on Text::tabSizeProperty method
  • 587f195: 8234474: [macos 10.15] Crash in file dialog in sandbox mode
  • f1108b0: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute
  • 63520a0: Merge
  • 3c4d68d: 8236626: Update copyright header for files modified in 2019
  • 580a2a9: 8087980: Add property to disable Monocle cursor
  • 3bbcbfb: 8225571: Port DND source to use GTK instead of GDK
  • 1952606: 8232811: Dialog's preferred size no longer accommodates multi-line strings
  • 4c6ebfb: 8236484: Compile error in monocle dispman
  • 8367e1a: 8130738: Add tabSize property to Text and TextFlow
  • 69e4ef3: 8235627: Blank stages when running JavaFX app in a macOS virtual machine
  • 5e0fb91: 8235364: Update copyright header for files modified in 2019
  • 8a5344c: Merge
  • 935e99d: 8207957: TableSkinUtils should not contain actual code implementation
  • 4e005e4: 8227808: Make GTK3 libraries mandatory for building on Linux
  • 1140d34: 8196587: Remove use of deprecated finalize method from JPEGImageLoader
  • d2d44b4: 8207759: VK_ENTER not consumed by TextField when default Button exists
  • fc539b5: 8223296: NullPointerException in GlassScene.java at line 325
  • 71ca899: 8220722: ProgressBarSkin: adds strong listener to control's width property
  • 2e0d01c: Merge
  • 07af89a: 8221334: TableViewSkin: must initialize flow's cellCount in constructor
  • 4ddf554: 8234916: [macos 10.15] Garbled text running with native-image
  • 46338d0: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
  • a68347c: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl
  • 1c27fbd: 8210955: DOMTest::testEventListenerCascade fails
  • 2d4096a: 8235151: Nonexistent notifyQuit method referred from iOS GlassHelper.m
  • 98035cb: 8211308: Support HTTP/2 in WebView
  • 6892fa1: 8232064: Switch FX build to use JDK 13.0.1 as boot JDK
  • 1d670f1: 8200224: Multiple press event when JFXPanel gains focus
  • 83eb0a7: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation
  • 798afbc: 8230610: Upgrade GStreamer to version 1.16.1
  • 126896d: 8234704: Fix attribution in libxslt.md
  • a96704e: Merge
  • 4d3c723: 8234593: Mark LeakTest.testGarbageCollectability as unstable
  • 5a39824: 8234056: Upgrade to libxslt 1.1.34
  • 8bea7b7: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors
  • aad1720: 8233420: Upgrade to gcc 8.3 on Linux
  • 42040c4: 8232063: Upgrade gradle to version 6.0
  • aab07a4: 8234239: [TEST_BUG] Reenable few ignored web tests
  • 95ad601: 8233421: Upgrade to Visual Studio 2017 version 15.9.16
  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests
  • e37cb37: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest
  • 4f496d4: 8234194: [TEST_BUG] Reenable few graphics unit tests
  • 71fa9af: Merge
  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests
  • dc01309: 8234110: SwingFXUtilsTest is unsuitable for unit test framework
  • 5b96ee4: 8231188: Update SQLite to version 3.30.1
  • d46dcae: 8233338: FX javadoc headings are out of sequence
  • 94bcf3f: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene
  • 286d1b5: 8230492: font-family not set in HTMLEditor if font name has a number in it
  • f74f3af: 8233040: ComboBoxPopupControl: remove eventFilter for F4
  • a1cc4ab: 8232210: Update Mesa 3-D Headers to version 19.2.1
  • dca8df4: 8232943: Gesture support is not initialized on iOS
  • 5a70b0c: 8189092: ArrayIndexOutOfBoundsException on Linux in getCachedGlyph
  • ac71396: 8232929: Duplicate symbols when building static libraries
  • a3711e2: Merge
  • 2d5d7e0: Merge
  • 962bdd1: 8232214: Improved internal validations
  • 2d2b824: 8232128: Better formatting for numbers
  • 81f7738: 8232121: Better numbering system
  • 8e55294: Merge
  • 1325f11: Merge
  • f759dd9: Merge
  • fed185a: Merge
  • 592d745: Merge
  • a0b4b14: 8227473: Improve gstreamer media support

Your commit was automatically rebased without conflicts.

Pushed as commit 2aed5ad.

@tobiasdiez tobiasdiez deleted the tobiasdiez:patch-1 branch Aug 14, 2020
@stefan-kolb stefan-kolb mentioned this pull request Aug 14, 2020
11 of 30 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants