Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8208169: can not print selected pages of web page #222

Closed
wants to merge 5 commits into from

Conversation

@bhaweshkc
Copy link
Collaborator

bhaweshkc commented May 15, 2020

Print function of WebEngine.java ignores page range setting and prints given number of pages starting from first page, which is the root cause of this issue. To fix it, put check for page ranges and if it available, use it for printing pages otherwise print all pages as usual.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8208169: can not print selected pages of web page

Reviewers

  • Phil Race (prr - Reviewer)
  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/222/head:pull/222
$ git checkout pull/222

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2020

👋 Welcome back bhaweshkc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 15, 2020
@mlbridge
Copy link

mlbridge bot commented May 15, 2020

@kevinrushforth
Copy link
Member

kevinrushforth commented May 15, 2020

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review May 15, 2020
@openjdk
Copy link

openjdk bot commented May 15, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

kevinrushforth commented May 15, 2020

@prrace can you also review this?

@kevinrushforth
Copy link
Member

kevinrushforth commented May 21, 2020

Can you add a test for this? It may need to be a manual test, in which case it can go into tests/manual/printing/.

Copy link
Collaborator

prrace left a comment

looks ok. Approval waiting on a test.

@bhaweshkc
Copy link
Collaborator Author

bhaweshkc commented Jun 14, 2020

@prrace
updated test which uses locally generated html content which should be large enough to cover 4 pages.

@prrace
prrace approved these changes Jun 15, 2020
Copy link
Member

kevinrushforth left a comment

Both the fix and the test look good. I left a couple minor formatting / style comments.

tests/manual/printing/PrintPageRangeTest.java Outdated Show resolved Hide resolved
tests/manual/printing/PrintPageRangeTest.java Outdated Show resolved Hide resolved
@prrace
prrace approved these changes Jun 17, 2020
@openjdk
Copy link

openjdk bot commented Jun 17, 2020

@bhaweshkc This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8208169: can not print selected pages of web page

Reviewed-by: prr, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 31 commits pushed to the master branch:

  • 1727dfa: 8247163: JFXPanel throws exception on click when no Scene is set
  • 54e2507: 8247360: Add missing license file for Microsoft DirectShow Samples
  • fb962ac: 8244418: MenuBar: IOOB exception on requestFocus on empty bar
  • bf2e972: 8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars
  • b200891: 8244824: TableView : Incorrect German translation
  • b2b46eb: 8242892: SpinnerValueFactory has an implicit no-arg constructor
  • afa805f: 8245575: Show the ContextMenu of input controls with long press gesture on iOS
  • 5304266: 8245635: GlassPasteboard::getUTFs fails on iOS
  • ba501ef: 8246357: Allow static build of webkit library on linux
  • a02e09d: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
  • ... and 21 more: https://git.openjdk.java.net/jfx/compare/7b0619004af2e2d1b1a32084ef92ff5cd3880900...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1727dfa4374172e3fc45ad98b27c64d619f534cd.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 17, 2020
@bhaweshkc
Copy link
Collaborator Author

bhaweshkc commented Jun 17, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jun 17, 2020
@openjdk
Copy link

openjdk bot commented Jun 17, 2020

@bhaweshkc
Your change (at version 456d0a1) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

kevinrushforth commented Jun 17, 2020

/sponsor

@openjdk openjdk bot closed this Jun 17, 2020
@openjdk openjdk bot added integrated and removed sponsor labels Jun 17, 2020
@openjdk openjdk bot removed the ready label Jun 17, 2020
@openjdk
Copy link

openjdk bot commented Jun 17, 2020

@kevinrushforth @bhaweshkc The following commits have been pushed to master since your change was applied:

  • 1727dfa: 8247163: JFXPanel throws exception on click when no Scene is set
  • 54e2507: 8247360: Add missing license file for Microsoft DirectShow Samples
  • fb962ac: 8244418: MenuBar: IOOB exception on requestFocus on empty bar
  • bf2e972: 8246348: Crash in libpango on Ubuntu 20.04 with some unicode chars
  • b200891: 8244824: TableView : Incorrect German translation
  • b2b46eb: 8242892: SpinnerValueFactory has an implicit no-arg constructor
  • afa805f: 8245575: Show the ContextMenu of input controls with long press gesture on iOS
  • 5304266: 8245635: GlassPasteboard::getUTFs fails on iOS
  • ba501ef: 8246357: Allow static build of webkit library on linux
  • a02e09d: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
  • 9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux
  • 6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
  • 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
  • a78b3fb: 8242523: Update the animation and clip envelope classes
  • 1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
  • 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
  • 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
  • 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
  • c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
  • 3ceee69: 8245499: Text input controls should show handles on iOS
  • 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
  • 16f446a: 8234876: Unit test classes should not extend Application
  • 2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
  • f3190db: 8244531: Tests: add support to identify recurring issues with controls et al
  • 1971c70: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest
  • 6e0b45a: 8245183: Two fxml unit tests log warnings about deprecated escape sequences
  • a13a642: 8244579: Windows "User Objects" leakage with WebView
  • 37b5edc: 8245456: MacPasteboard throws ClassCastException on static builds
  • 6e03930: 8237602: TabPane doesn't respect order of TabPane.getTabs() list
  • bb24322: 8244112: Skin implementations: must not violate contract of dispose
  • dbb6437: 8244647: Wrong first layout pass of Scrollbar controls on touch supported devices

Your commit was automatically rebased without conflicts.

Pushed as commit 8440b64.

@openjdk openjdk bot removed the rfr label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.