8245282: Button/Combo Behavior: memory leak on dispose

[kleopatra]

Reason for the memory leak is a listener on control's focusProperty that is not correctly removed on dispose. For details please see the report.

Added a test method to ButtonSkinTest that failed before and passes after the fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8245282: Button/Combo Behavior: memory leak on dispose

Reviewers

• Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/226/head:pull/226
$ git checkout pull/226

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 01: Full (56f3389)
• 00: Full (391331a)

[kleopatra]

changed to WIP: just noticed that all ComboXXBehaviors have exactly the same issue with exactly the same fix. So will widen the bug report to include these as well and wait with fixing this until JDK-8244531 is integrated (which can then be used here for cross-behavior tests)

on changing the title, the bot lost the connection to the bug report, for convenience here it is again: JDK-8245282

[openjdk]

@kleopatra This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245282: Button/Combo Behavior: memory leak on dispose

Reviewed-by: arapte

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 9 commits pushed to the master branch:

• a78b3fb: 8242523: Update the animation and clip envelope classes
• 1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
• 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
• 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
• 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
• c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
• 3ceee69: 8245499: Text input controls should show handles on iOS
• 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
• 16f446a: 8234876: Unit test classes should not extend Application

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate a78b3fb50e6d42e3ae2b30cf807343bee9438981.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kleopatra]

/integrate

[openjdk]

@kleopatra
Your change (at version 56f3389) is now ready to be sponsored by a Committer.

[arapte]

/sponsor

[openjdk]

@arapte @kleopatra The following commits have been pushed to master since your change was applied:

• a78b3fb: 8242523: Update the animation and clip envelope classes
• 1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
• 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
• 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
• 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
• c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
• 3ceee69: 8245499: Text input controls should show handles on iOS
• 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
• 16f446a: 8234876: Unit test classes should not extend Application

Your commit was automatically rebased without conflicts.

Pushed as commit 853ac78.