Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test #230

Closed
wants to merge 2 commits into from
Closed

8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test #230

wants to merge 2 commits into from

Conversation

arapte
Copy link
Member

@arapte arapte commented May 21, 2020 •
edited by openjdk bot
Loading

As discussed here during #201 , This PR converts the system tests in TabPanePermuteGetTabsTest.java to unit test.

Thanks @kleopatra , for providing the test. I have added few more tests and found few failures.
JDK-8245528 is created to fix these failures, the failing tests are currently ignored using this bug.

Please take a look.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/230/head:pull/230
$ git checkout pull/230

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2020

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label May 21, 2020
@mlbridge
Copy link

mlbridge bot commented May 21, 2020 •
edited
Loading

Webrevs

kevinrushforth
kevinrushforth reviewed May 21, 2020
View reviewed changes
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a more careful review + test later. I left a few inline comments below.

modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java Show resolved Hide resolved
modules/javafx.controls/src/shims/java/javafx/scene/control/skin/TabPaneSkinShim.java Show resolved Hide resolved
...javafx.controls/src/test/java/test/javafx/scene/control/skin/TabPaneSkinHeaderOrderTest.java Show resolved Hide resolved
...javafx.controls/src/test/java/test/javafx/scene/control/skin/TabPaneSkinHeaderOrderTest.java Outdated Show resolved Hide resolved
...javafx.controls/src/test/java/test/javafx/scene/control/skin/TabPaneSkinHeaderOrderTest.java Show resolved Hide resolved
kevinrushforth
kevinrushforth approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 29, 2020 •
edited
Loading

@arapte This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 12 commits pushed to the master branch:

  • 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
  • 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
  • 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
  • c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
  • 3ceee69: 8245499: Text input controls should show handles on iOS
  • 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
  • 16f446a: 8234876: Unit test classes should not extend Application
  • 2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
  • f3190db: 8244531: Tests: add support to identify recurring issues with controls et al
  • 1971c70: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest
  • ... and 2 more: https://git.openjdk.java.net/jfx/compare/37b5edc718c7538086938712f2d69ef4690c343a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 804ccced129f4780ef4af618dd225278777e8272.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 29, 2020
@arapte
Copy link
Member Author

arapte commented May 30, 2020

/integrate

@openjdk openjdk bot closed this May 30, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated labels May 30, 2020
@openjdk
Copy link

openjdk bot commented May 30, 2020

@arapte The following commits have been pushed to master since your change was applied:

  • 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
  • 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
  • c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
  • 3ceee69: 8245499: Text input controls should show handles on iOS
  • 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
  • 16f446a: 8234876: Unit test classes should not extend Application
  • 2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
  • f3190db: 8244531: Tests: add support to identify recurring issues with controls et al
  • 1971c70: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest
  • 6e0b45a: 8245183: Two fxml unit tests log warnings about deprecated escape sequences
  • a13a642: 8244579: Windows "User Objects" leakage with WebView

Your commit was automatically rebased without conflicts.

Pushed as commit 804ccce.

@openjdk openjdk bot removed the rfr Ready for review label May 30, 2020
@arapte arapte deleted the Convert_TabPanePermuteGetTabsTest_to_unit_test branch May 10, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrushforth kevinrushforth kevinrushforth approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated
Milestone
No milestone
2 participants
@arapte @kevinrushforth