New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8245499: Text input controls should show handles on iOS #231
Conversation
👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into |
Webrevs
|
/reviewers 2 |
@kevinrushforth |
Since this touches shared code, I'd like @aghaisas to look at this. |
Code changes look OK. |
modules/javafx.controls/src/ios/resources/com/sun/javafx/scene/control/skin/caspian/ios.css
Outdated
Show resolved
Hide resolved
modules/javafx.controls/src/ios/resources/com/sun/javafx/scene/control/skin/modena/ios.css
Outdated
Show resolved
Hide resolved
I've edited the PR description with details of the tests I've done. |
@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 7 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas, @johanvos) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@jperedadnr |
/sponsor |
@aghaisas @jperedadnr The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 3ceee69. |
After JDK-8242167, a JavaFX control is used for text input on iOS instead of the native control, on a touch enabled device. However, selection handles are not enabled and currently text selection is not possible at all.
This PR enables handles on iOS as in the rest of the platforms with touch support.
It also tries to accommodate its style to the native style for handles, where selection handles have a circle shape and are a little bit bigger, and there is no caret handle.
I've tested it on iPhone, running a small HelloFX sample, with a TextField control.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/231/head:pull/231
$ git checkout pull/231