8245499: Text input controls should show handles on iOS

[jperedadnr]

After JDK-8242167, a JavaFX control is used for text input on iOS instead of the native control, on a touch enabled device. However, selection handles are not enabled and currently text selection is not possible at all.

This PR enables handles on iOS as in the rest of the platforms with touch support.

It also tries to accommodate its style to the native style for handles, where selection handles have a circle shape and are a little bit bigger, and there is no caret handle.

I've tested it on iPhone, running a small HelloFX sample, with a TextField control.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8245499: Text input controls should show handles on iOS

Reviewers

• Ajit Ghaisas (aghaisas - Reviewer)
• Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/231/head:pull/231
$ git checkout pull/231

[bridgekeeper]

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (fc681a1)
• 00: Full (4933c7d)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

Since this touches shared code, I'd like @aghaisas to look at this.

[aghaisas]

Code changes look OK.
I think, we need a note in PR description about what testing you have done with this fix.

[jperedadnr]

I've edited the PR description with details of the tests I've done.

[openjdk]

@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245499: Text input controls should show handles on iOS

Reviewed-by: aghaisas, jvos

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch:

• 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
• 16f446a: 8234876: Unit test classes should not extend Application
• 2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
• f3190db: 8244531: Tests: add support to identify recurring issues with controls et al
• 1971c70: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest
• 6e0b45a: 8245183: Two fxml unit tests log warnings about deprecated escape sequences
• a13a642: 8244579: Windows "User Objects" leakage with WebView

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 8914bd2a7fe442239922ceecb6678d1e17549f1e.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas, @johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jperedadnr]

/integrate

[openjdk]

@jperedadnr
Your change (at version fc681a1) is now ready to be sponsored by a Committer.

[aghaisas]

/sponsor

[openjdk]

@aghaisas @jperedadnr The following commits have been pushed to master since your change was applied:

• 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
• 16f446a: 8234876: Unit test classes should not extend Application
• 2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
• f3190db: 8244531: Tests: add support to identify recurring issues with controls et al
• 1971c70: 8245457: TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest
• 6e0b45a: 8245183: Two fxml unit tests log warnings about deprecated escape sequences
• a13a642: 8244579: Windows "User Objects" leakage with WebView

Your commit was automatically rebased without conflicts.

Pushed as commit 3ceee69.