Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245601: [TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE #234

Closed

Conversation

@arapte
Copy link

arapte commented May 22, 2020

The reordering tests in TabPaneDragPolicyTest fail only fails on Mac. It may be a a product issue which is tracked by JDK-8213136. This PR disables the 4 reordering test on Mac platform. And fixes an Exception, Please check the JBS for exception.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8245601: [TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE ⚠️ Title mismatch between PR and JBS.

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/234/head:pull/234
$ git checkout pull/234

…3136 is fixed and fix ISE
@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2020

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 22, 2020
@mlbridge
Copy link

mlbridge bot commented May 22, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented May 23, 2020

@arapte This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 2d98fe6: 8245601: TESTBUG] Disable TabPaneDragPolicyTest on Mac until JDK-8213136 is fixed and fix ISE
  • f3190db: 8244531: Tests: add support to identify recurring issues with controls et al

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2d98fe6cae71673cf1de89b39846a13d9505c4c4.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 23, 2020
@arapte
Copy link
Author

arapte commented May 26, 2020

/integrate

@openjdk openjdk bot closed this May 26, 2020
@openjdk openjdk bot added integrated and removed ready labels May 26, 2020
@openjdk
Copy link

openjdk bot commented May 26, 2020

@arapte The following commits have been pushed to master since your change was applied:

  • f3190db: 8244531: Tests: add support to identify recurring issues with controls et al

Your commit was automatically rebased without conflicts.

Pushed as commit 2d98fe6.

@openjdk openjdk bot removed the rfr label May 26, 2020
@arapte arapte deleted the arapte:disable_TabPaneDragPolicyTest_On_Mac branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.