Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245644: Change JavaFX release version in jfx14 branch to 14.0.2 #235

Closed
wants to merge 1 commit into from

Conversation

@johanvos
Copy link
Collaborator

@johanvos johanvos commented May 22, 2020

Increase security number for the 14.0.2 release
Fix for JDK-8245644


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8245644: Change JavaFX release version in jfx14 branch to 14.0.2

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/235/head:pull/235
$ git checkout pull/235

Fix for JDK-8245644
@johanvos johanvos requested a review from kevinrushforth May 22, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 22, 2020

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into jfx14 will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 22, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 22, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 22, 2020

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245644: Change JavaFX release version in jfx14 branch to 14.0.2

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the jfx14 branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 331a39be016a284e5495c73726e7b58e7769a75e.

➡️ To integrate this PR with the above commit message to the jfx14 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 22, 2020
@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented May 22, 2020

/integrate

@openjdk openjdk bot closed this May 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 22, 2020

@johanvos
Pushed as commit 5f9ba88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants