8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

[kleopatra]

Both skins have similar misbehavior when switching skins

• memory leak due to a manually added but not removed change listener
• NPE when modifying items after skin switch due to a not removed listener to the control's items

Fixed in both (for details see the issue). Added SkinCleanupTest for simple testing of per-control side-effects, removed both skins from memory test exclusion list: failing before and passing after fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

Reviewers

• Ajit Ghaisas (aghaisas - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/238/head:pull/238
$ git checkout pull/238

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (20ba4b1)

[openjdk]

@kleopatra This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

Reviewed-by: aghaisas

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 8 commits pushed to the master branch:

• 1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
• 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
• 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
• 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
• c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
• 3ceee69: 8245499: Text input controls should show handles on iOS
• 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
• 16f446a: 8234876: Unit test classes should not extend Application

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1ab653cb5923fdc085fd5ec2f106a31979a71b5c.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kleopatra]

/integrate

[openjdk]

@kleopatra
Your change (at version 20ba4b1) is now ready to be sponsored by a Committer.

[aghaisas]

/sponsor

[openjdk]

@aghaisas @kleopatra The following commits have been pushed to master since your change was applied:

• 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
• 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
• 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
• c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"
• 3ceee69: 8245499: Text input controls should show handles on iOS
• 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently
• 16f446a: 8234876: Unit test classes should not extend Application

Your commit was automatically rebased without conflicts.

Pushed as commit 1ab653c.