Skip to content

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented May 27, 2020

This is a simple test fix.

Issue : https://bugs.openjdk.java.net/browse/JDK-8245634

After fixing JDK-8245457, I found that there are more ignored tests of similar nature that can be enabled and fixed.
A search for ignored tests with message "impl_cssSet API removed" - revealed a total 6 occurrences in 4 files -

  1. CellTest
  2. CheckBoxTest
  3. ChoiceBoxTest
  4. DateCellTest

This PR enables and fixes these tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"

Reviewers

  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/239/head:pull/239
$ git checkout pull/239

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label May 27, 2020
@mlbridge
Copy link

mlbridge bot commented May 27, 2020

Webrevs

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@openjdk
Copy link

openjdk bot commented May 29, 2020

@aghaisas This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"

Reviewed-by: arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 3ceee69: 8245499: Text input controls should show handles on iOS
  • 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 3ceee69938ebdf90dc4e7f7ff577912939144095.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 29, 2020
@aghaisas
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this May 29, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels May 29, 2020
@openjdk
Copy link

openjdk bot commented May 29, 2020

@aghaisas The following commits have been pushed to master since your change was applied:

  • 3ceee69: 8245499: Text input controls should show handles on iOS
  • 8914bd2: 8234540: javafx.web LeakTest.testGarbageCollectability fails intermittently

Your commit was automatically rebased without conflicts.

Pushed as commit c41777e.

@aghaisas aghaisas deleted the 8245634_fix_ignored_tests branch July 27, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants