-
Notifications
You must be signed in to change notification settings - Fork 541
8246099: Intermittent test failures in SandboxAppTest #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
johanvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
|
/integrate |
|
@kevinrushforth The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 168b7f7. |
This is a fix for an intermittent test failure, due to a timeout, in
SandboxAppTestthat we are starting to see on some of our test machines.The failure is happening because of a 10 second timeout in the launched application. This doesn't seem to be enough to run the test to completion in all cases. I note that the similar launched apps, such as those launched by
MainLauncherTest,ModuleLauncherTest, andJarLauncherTestdon't have a timeout (they just rely on the timeout value of the launching test itself).The app timeout was just added to prevent the test suite from hanging if the application were to get stuck, so there is no need for it to be such a small value (nor to have it be less than the test timeout).
The proposed solution is to increase the app timeout to 30 seconds (up from 10) and the test timeout to 25 (up from 15).
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/241/head:pull/241$ git checkout pull/241