Skip to content

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 28, 2020

This is a fix for an intermittent test failure, due to a timeout, in SandboxAppTest that we are starting to see on some of our test machines.

The failure is happening because of a 10 second timeout in the launched application. This doesn't seem to be enough to run the test to completion in all cases. I note that the similar launched apps, such as those launched by MainLauncherTest, ModuleLauncherTest, and JarLauncherTest don't have a timeout (they just rely on the timeout value of the launching test itself).

The app timeout was just added to prevent the test suite from hanging if the application were to get stuck, so there is no need for it to be such a small value (nor to have it be less than the test timeout).

The proposed solution is to increase the app timeout to 30 seconds (up from 10) and the test timeout to 25 (up from 15).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8246099: Intermittent test failures in SandboxAppTest

Reviewers

  • Ambarish Rapte (arapte - Reviewer)
  • Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/241/head:pull/241
$ git checkout pull/241

@kevinrushforth kevinrushforth self-assigned this May 28, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label May 28, 2020
@mlbridge
Copy link

mlbridge bot commented May 28, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented May 29, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8246099: Intermittent test failures in SandboxAppTest

Reviewed-by: arapte, jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c41777e308f1c44f34e4fafa2006208da0f82626.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 29, 2020
Copy link
Collaborator

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kevinrushforth
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 29, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated labels May 29, 2020
@openjdk
Copy link

openjdk bot commented May 29, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"

Your commit was automatically rebased without conflicts.

Pushed as commit 168b7f7.

@openjdk openjdk bot removed the rfr Ready for review label May 29, 2020
@kevinrushforth kevinrushforth deleted the 8246099-sandbox-test branch June 8, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants