8239095: Upgrade libFFI to the latest 3.3 version

[sashamatveev]

• Updated libffi to 3.3.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8239095: Upgrade libFFI to the latest 3.3 version

Reviewers

• Johan Vos (jvos - Reviewer)
• Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/242/head:pull/242
$ git checkout pull/242

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[mlbridge]

Webrevs

• 00: Full (66f4cf4)

[kevinrushforth]

@arapte Can you review as well?

[kevinrushforth]

Initial testing looks good. I'll finish my testing & review on Monday.

[arapte]

In the original release of libffi 3.2.1, this line is not commented. which means it was commented in JavaFX. I cannot trace when and why was it commented. Should it be reasoned to whether enable it or not ?

[johanvos]

That's a good question. The commented line was there from the first commit (in 9, changeset 9231:241f9696e3ad, https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason on why it was disabled.

libffi is also built in the GraalVM project, and that line is not commented there.

@sashamatveev or @kevinrushforth do you remember the reason?

[kevinrushforth]

No, I don't remember.

[sashamatveev]

No, I don't remember as well.

[johanvos]

I tested this and couldn't find issues. The uncommented line worries me a bit, though, but I can't see a reason why it should be commented again.

[kevinrushforth]

Looks good to me.

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8239095: Upgrade libFFI to the latest 3.3 version

Reviewed-by: jvos, kcr

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch:

• 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
• a78b3fb: 8242523: Update the animation and clip envelope classes
• 1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
• 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
• 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
• 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
• c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 853ac78ad5099ebda00dc401b3ead67cafa59aa8.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sashamatveev]

/integrate

[openjdk]

@sashamatveev The following commits have been pushed to master since your change was applied:

• 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
• a78b3fb: 8242523: Update the animation and clip envelope classes
• 1ab653c: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin
• 804ccce: 8244195: [TEST_BUG] Convert the system tests TabPanePermuteGetTabsTest to unit test
• 9edba9c: 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
• 168b7f7: 8246099: Intermittent test failures in SandboxAppTest
• c41777e: 8245634: [TestBug] Enable and fix tests ignored with message "impl_cssSet API removed"

Your commit was automatically rebased without conflicts.

Pushed as commit 6bd0e22.