New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8246204: No 3D support for newer Intel graphics drivers on Linux #243
Conversation
👋 Welcome back mpaus! A progress list of the required criteria for merging this PR into |
Here is the crosslink to the JBS issue: https://bugs.openjdk.java.net/browse/JDK-8246204 |
Webrevs
|
modules/javafx.graphics/src/main/java/com/sun/prism/es2/X11GLFactory.java
Show resolved
Hide resolved
My original intention was to keep two entries in order to make it clearer that there are currently two distinct vendor strings for Intel floating around. But having just one entry which covers both cases is ok for me too.
@mipastgt This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 3 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@kevinrushforth @mipastgt The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 9749982. |
It seems to be sufficient to add "intel" as an additional vendor to the list in the X11GLFactory class. Tests pass and my own application also works with the new build.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/243/head:pull/243
$ git checkout pull/243