Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8246204: No 3D support for newer Intel graphics drivers on Linux #243

Closed
wants to merge 2 commits into from

Conversation

@mipastgt
Copy link
Member

mipastgt commented Jun 1, 2020

It seems to be sufficient to add "intel" as an additional vendor to the list in the X11GLFactory class. Tests pass and my own application also works with the new build.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8246204: No 3D support for newer Intel graphics drivers on Linux

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/243/head:pull/243
$ git checkout pull/243

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2020

👋 Welcome back mpaus! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 1, 2020
@mipastgt
Copy link
Member Author

mipastgt commented Jun 1, 2020

Here is the crosslink to the JBS issue: https://bugs.openjdk.java.net/browse/JDK-8246204

@mlbridge
Copy link

mlbridge bot commented Jun 1, 2020

Webrevs

My original intention was to keep two entries in order to make it clearer that there are currently two distinct vendor strings for Intel floating around. But having just one entry which covers both cases is ok for me too.
@openjdk
Copy link

openjdk bot commented Jun 4, 2020

@mipastgt This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8246204: No 3D support for newer Intel graphics drivers on Linux

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
  • 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
  • a78b3fb: 8242523: Update the animation and clip envelope classes

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 6bd0e22d7e33a7e24f17a351914c9ab78a0c3398.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 4, 2020
@mipastgt
Copy link
Member Author

mipastgt commented Jun 4, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jun 4, 2020
@openjdk
Copy link

openjdk bot commented Jun 4, 2020

@mipastgt
Your change (at version 4142adb) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

kevinrushforth commented Jun 4, 2020

/sponsor

@openjdk openjdk bot closed this Jun 4, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Jun 4, 2020
@openjdk
Copy link

openjdk bot commented Jun 4, 2020

@kevinrushforth @mipastgt The following commits have been pushed to master since your change was applied:

  • 6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
  • 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
  • a78b3fb: 8242523: Update the animation and clip envelope classes

Your commit was automatically rebased without conflicts.

Pushed as commit 9749982.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.