Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8246357: Allow static build of webkit library on linux #245

Closed
wants to merge 1 commit into from

Conversation

@johanvos
Copy link
Collaborator

johanvos commented Jun 2, 2020

add changes to build a static version of libjfxwebkit.a
Fox for JDK-8246357


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8246357: Allow static build of webkit library on linux

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Arun Joseph (ajoseph - Committer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/245/head:pull/245
$ git checkout pull/245

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2020

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 2, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2020

Webrevs

@kevinrushforth kevinrushforth self-requested a review Jun 2, 2020
@kevinrushforth
Copy link
Member

kevinrushforth commented Jun 2, 2020

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jun 2, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

kevinrushforth commented Jun 2, 2020

@arun-Joseph @guruhb can one of you also review?

@kevinrushforth
Copy link
Member

kevinrushforth commented Jun 3, 2020

The diffs look good. I'm doing test builds now.

Copy link
Member

arun-Joseph left a comment

Changes looks good to me.

@openjdk
Copy link

openjdk bot commented Jun 3, 2020

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8246357: Allow static build of webkit library on linux

Reviewed-by: kcr, ajoseph
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 6 commits pushed to the master branch:

  • ba501ef: 8246357: Allow static build of webkit library on linux
  • a02e09d: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
  • 9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux
  • 6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
  • 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
  • a78b3fb: 8242523: Update the animation and clip envelope classes

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ba501ef29fefbe44d7a0972b607b964b34e62242.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@johanvos
Copy link
Collaborator Author

johanvos commented Jun 9, 2020

/integrate

@openjdk openjdk bot closed this Jun 9, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 9, 2020
@openjdk
Copy link

openjdk bot commented Jun 9, 2020

@johanvos The following commits have been pushed to master since your change was applied:

  • a02e09d: 8246195: ListViewSkin/Behavior: misbehavior on switching skin
  • 9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux
  • 6bd0e22: 8239095: Upgrade libFFI to the latest 3.3 version
  • 853ac78: 8245282: Button/Combo Behavior: memory leak on dispose
  • a78b3fb: 8242523: Update the animation and clip envelope classes

Your commit was automatically rebased without conflicts.

Pushed as commit ba501ef.

@openjdk openjdk bot removed the rfr label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.