Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8246195: ListViewSkin/Behavior: misbehavior on switching skin #247

Closed
wants to merge 1 commit into from

Conversation

@kleopatra
Copy link
Collaborator

kleopatra commented Jun 4, 2020

Cleanup memory leaks and malicious side-effects (produced by eventhandlers and listeners that were not removed) when replacing a ListViewSkin.

The fix is to remove the listeners/handlers as needed. Added tests that failed before and pass after the fix.

It's part of the ongoing cleanup effort JDK-8241364.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8246195: ListViewSkin/Behavior: misbehavior on switching skin

Reviewers

  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/247/head:pull/247
$ git checkout pull/247

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2020

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 4, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2020

Webrevs

@arapte
arapte approved these changes Jun 5, 2020
@openjdk
Copy link

openjdk bot commented Jun 5, 2020

@kleopatra This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8246195: ListViewSkin/Behavior: misbehavior on switching skin

Reviewed-by: arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 97499820c869c825c454740bc2ba66d4d81db0a6.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 5, 2020
@kleopatra
Copy link
Collaborator Author

kleopatra commented Jun 5, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jun 5, 2020
@openjdk
Copy link

openjdk bot commented Jun 5, 2020

@kleopatra
Your change (at version 2b0c248) is now ready to be sponsored by a Committer.

@arapte
Copy link
Member

arapte commented Jun 8, 2020

/sponsor

@openjdk openjdk bot closed this Jun 8, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Jun 8, 2020
@openjdk
Copy link

openjdk bot commented Jun 8, 2020

@arapte @kleopatra The following commits have been pushed to master since your change was applied:

  • 9749982: 8246204: No 3D support for newer Intel graphics drivers on Linux

Your commit was automatically rebased without conflicts.

Pushed as commit a02e09d.

@kleopatra kleopatra deleted the kleopatra:bug-fix-8246195 branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.