Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242892: SpinnerValueFactory has an implicit no-arg constructor #250

Closed
wants to merge 1 commit into from

Conversation

@aghaisas
Copy link
Collaborator

aghaisas commented Jun 10, 2020

Issue : https://bugs.openjdk.java.net/browse/JDK-8242892

Fix : Added a constructor to SpinnerValueFactory class with minimal description.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242892: SpinnerValueFactory has an implicit no-arg constructor

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/250/head:pull/250
$ git checkout pull/250

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 10, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 11, 2020

@aghaisas This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242892: SpinnerValueFactory has an implicit no-arg constructor

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate afa805fe8b87f6d9bda60b69e9365ea521439cb7.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 11, 2020
@aghaisas
Copy link
Collaborator Author

aghaisas commented Jun 12, 2020

/integrate

@openjdk openjdk bot closed this Jun 12, 2020
@openjdk openjdk bot added the integrated label Jun 12, 2020
@openjdk
Copy link

openjdk bot commented Jun 12, 2020

@aghaisas
Pushed as commit b2b46eb.

@openjdk openjdk bot removed ready rfr labels Jun 12, 2020
@aghaisas aghaisas deleted the aghaisas:avoid_implicit_constructor branch Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.