Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
8246745: ListCell/Skin: misbehavior on switching skin #251
ListCellSkin installs listeners to the ListView/fixedCellSize that introduce a memory leak, NPE on replacing the listView and incorrect update of internal state (see bug report for details)
Fixed by removing the listeners (and the internal state had been copied from listView on change) and access of listView state when needed.
Added tests that failed before and pass after the fix, plus a sanity test to guarantee same (correct) behavior before/after.
After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 74 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
@kleopatra Since your change was applied there have been 74 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 0514116.