Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247360: Add missing license file for Microsoft DirectShow Samples #252

Closed

Conversation

@kevinrushforth
Copy link
Member

kevinrushforth commented Jun 16, 2020

This adds a missing third-party license file for the Microsoft DirectShow Samples.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8247360: Add missing license file for Microsoft DirectShow Samples

Reviewers

  • Alexander Matveev (almatvee - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/252/head:pull/252
$ git checkout pull/252

@kevinrushforth kevinrushforth self-assigned this Jun 16, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jun 16, 2020

@sashamatveev can you review this?

@openjdk openjdk bot added the rfr label Jun 16, 2020
@openjdk
Copy link

openjdk bot commented Jun 16, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8247360: Add missing license file for Microsoft DirectShow Samples

Reviewed-by: almatvee
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate fb962ac2631a98b8e1073a85dd9df094ba29c7ad.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 16, 2020
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Jun 16, 2020

/integrate

@openjdk openjdk bot closed this Jun 16, 2020
@openjdk openjdk bot added integrated and removed ready labels Jun 16, 2020
@openjdk
Copy link

openjdk bot commented Jun 16, 2020

@kevinrushforth
Pushed as commit 54e2507.

@openjdk openjdk bot removed the rfr label Jun 16, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2020

Webrevs

@kevinrushforth kevinrushforth deleted the kevinrushforth:8247360-directshow.md branch Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.