Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8201570: Get two bytes for the Linux input event type, not four #257

Closed
wants to merge 1 commit into from

Conversation

@jgneff
Copy link
Contributor

jgneff commented Jun 27, 2020

Fixes JDK-8201570.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8201570: Get two bytes for the Linux input event type, not four

Reviewers

  • Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/257/head:pull/257
$ git checkout pull/257

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2020

👋 Welcome back jgneff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 27, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2020

Webrevs

Copy link
Collaborator

johanvos left a comment

This fixes a bug that currently didn't cause any harm (https://bugs.openjdk.java.net/browse/JDK-8201570?focusedCommentId=14172176) , but it's better to fix it now.

@openjdk
Copy link

openjdk bot commented Jun 29, 2020

@jgneff This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8201570: Get two bytes for the Linux input event type, not four

Reviewed-by: jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 9 commits pushed to the master branch:

  • f3a0446: 8247963: Update SQLite to version 3.32.3
  • 32584db: 8238954: Improve performance of tiled snapshot rendering
  • 869ea40: 8244212: Optionally download media and webkit libraries from latest openjfx EA build
  • 62f8cee: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo
  • 527cc2b: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine
  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts
  • 15f97ed: 8240264: iOS: Unnecessary logging on every pulse when GL context changes
  • 2ca509a: 8193800: TreeTableView selection changes on sorting
  • a5878e0: 8214699: Node.getPseudoClassStates must return the same instance on every call

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate f3a0446592dd7a3576384eae987b0099b5a9d8c8.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 29, 2020
@johanvos
Copy link
Collaborator

johanvos commented Jul 1, 2020

@jgneff you can proceed with this and integrate it. Once you do that, I'll sponsor the commit.

@jgneff
Copy link
Contributor Author

jgneff commented Jul 1, 2020

/integrate

@openjdk
Copy link

openjdk bot commented Jul 1, 2020

@jgneff
Your change (at version ba16fb6) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Jul 1, 2020
@johanvos
Copy link
Collaborator

johanvos commented Jul 2, 2020

/sponsor

@openjdk openjdk bot closed this Jul 2, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Jul 2, 2020
@openjdk
Copy link

openjdk bot commented Jul 2, 2020

@johanvos @jgneff The following commits have been pushed to master since your change was applied:

  • f3a0446: 8247963: Update SQLite to version 3.32.3
  • 32584db: 8238954: Improve performance of tiled snapshot rendering
  • 869ea40: 8244212: Optionally download media and webkit libraries from latest openjfx EA build
  • 62f8cee: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo
  • 527cc2b: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine
  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts
  • 15f97ed: 8240264: iOS: Unnecessary logging on every pulse when GL context changes
  • 2ca509a: 8193800: TreeTableView selection changes on sorting
  • a5878e0: 8214699: Node.getPseudoClassStates must return the same instance on every call

Your commit was automatically rebased without conflicts.

Pushed as commit 126637f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.