Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine #259

Closed

Conversation

@aghaisas
Copy link
Collaborator

aghaisas commented Jun 30, 2020

Issue : https://bugs.openjdk.java.net/browse/JDK-8248551
Fix : Added a check whether 'Nashorn' script engine is available before running the identified tests, otherwise tests are ignored.

Testing :

  1. With JDK-14, these tests pass- but they log a warning (same as existing behavior without this PR)
  2. With JDK-15-ea, these tests get ignored.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/259/head:pull/259
$ git checkout pull/259

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 30, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 30, 2020

@aghaisas This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 45c9854ce9b5dc38638f6d2426db3f63d2361cd1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 30, 2020
@aghaisas
Copy link
Collaborator Author

aghaisas commented Jun 30, 2020

/integrate

@openjdk openjdk bot closed this Jun 30, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 30, 2020
@openjdk
Copy link

openjdk bot commented Jun 30, 2020

@aghaisas The following commits have been pushed to master since your change was applied:

  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

Your commit was automatically rebased without conflicts.

Pushed as commit 527cc2b.

@aghaisas aghaisas deleted the aghaisas:8248551_ignore_2_fxml_tests branch Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.