Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248317: Change JavaFX release version to 16 #260

Closed
wants to merge 1 commit into from

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 30, 2020

Bump the version number of JavaFX to 16. I will integrate this immediately after forking the jfx15 stabilization branch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Ambarish Rapte (arapte - Reviewer)
  • Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/260/head:pull/260
$ git checkout pull/260

@kevinrushforth kevinrushforth self-assigned this Jun 30, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jun 30, 2020

@arapte please review

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 30, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 30, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 30, 2020

Webrevs

@arapte
arapte approved these changes Jun 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8248317: Change JavaFX release version to 16

Reviewed-by: arapte, jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch:

  • 126637f: 8201570: Get two bytes for the Linux input event type, not four
  • f3a0446: 8247963: Update SQLite to version 3.32.3
  • 32584db: 8238954: Improve performance of tiled snapshot rendering
  • 869ea40: 8244212: Optionally download media and webkit libraries from latest openjfx EA build
  • 62f8cee: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo
  • 527cc2b: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine
  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 126637f5889fb9338606f6d69b3045d28c2094aa.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 30, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 2, 2020

/integrate

@openjdk openjdk bot closed this Jul 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • 126637f: 8201570: Get two bytes for the Linux input event type, not four
  • f3a0446: 8247963: Update SQLite to version 3.32.3
  • 32584db: 8238954: Improve performance of tiled snapshot rendering
  • 869ea40: 8244212: Optionally download media and webkit libraries from latest openjfx EA build
  • 62f8cee: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo
  • 527cc2b: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine
  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

Your commit was automatically rebased without conflicts.

Pushed as commit a4f3150.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8248317-jfx-16 branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants