Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247963: Update SQLite to version 3.32.3 #261

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Jul 1, 2020

We currently use SQLite version 3.31.1. We should update to the latest stable release version 3.32.3 released on 2020-06-18.
https://www.sqlite.org/index.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/261/head:pull/261
$ git checkout pull/261

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 1, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 1, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 1, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth kevinrushforth self-requested a review Jul 1, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 1, 2020

@guruhb @bhaweshkc can one of you review this as well?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 1, 2020

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. Tested on all three platforms.

@guruhb
guruhb approved these changes Jul 2, 2020
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@arun-Joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8247963: Update SQLite to version 3.32.3

Reviewed-by: kcr, ghb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch:

  • 32584db: 8238954: Improve performance of tiled snapshot rendering
  • 869ea40: 8244212: Optionally download media and webkit libraries from latest openjfx EA build
  • 62f8cee: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo
  • 527cc2b: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine
  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts
  • 15f97ed: 8240264: iOS: Unnecessary logging on every pulse when GL context changes
  • 2ca509a: 8193800: TreeTableView selection changes on sorting

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 32584dba7209d727d732aed40019af83a75661ec.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 2, 2020
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Jul 2, 2020

/integrate

@openjdk openjdk bot closed this Jul 2, 2020
@openjdk openjdk bot added integrated and removed ready labels Jul 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2020

@arun-Joseph The following commits have been pushed to master since your change was applied:

  • 32584db: 8238954: Improve performance of tiled snapshot rendering
  • 869ea40: 8244212: Optionally download media and webkit libraries from latest openjfx EA build
  • 62f8cee: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo
  • 527cc2b: 8248551: [TestBug] Ignore two failing FXML unit tests which use Nashorn script engine
  • 45c9854: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts
  • 15f97ed: 8240264: iOS: Unnecessary logging on every pulse when GL context changes
  • 2ca509a: 8193800: TreeTableView selection changes on sorting

Your commit was automatically rebased without conflicts.

Pushed as commit f3a0446.

@openjdk openjdk bot removed the rfr label Jul 2, 2020
@arun-Joseph arun-Joseph deleted the arun-Joseph:8247963 branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants