Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8245284: Update to 610.1 version of WebKit #263

Closed
wants to merge 2 commits into from
Closed

8245284: Update to 610.1 version of WebKit #263

wants to merge 2 commits into from

Conversation

arun-joseph
Copy link
Member

@arun-joseph arun-joseph commented Jul 10, 2020 •
edited by openjdk bot

Update JavaFX WebKit to GTK WebKit 2.28 (610.1)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Bhawesh Choudhary (bchoudhary - Author)
  • Joeri Sykora (sykora - Author)

Contributors

  • Guru Hb <ghb@openjdk.org>
  • Bhawesh Choudhary <bchoudhary@openjdk.org>

Download

$ git fetch https://git.openjdk.java.net/jfx pull/263/head:pull/263
$ git checkout pull/263

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Jul 10, 2020
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2020

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 3

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 3 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

@bhaweshkc @johanvos can you also review this?

@arun-joseph
Copy link
Member Author

/contributor add Bhawesh Choudhary bhawesh.choudhary@oracle.com

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@arun-joseph
Contributor Bhawesh Choudhary <bhawesh.choudhary@oracle.com> successfully added.

@arun-joseph
Copy link
Member Author

/contributor add Guru HB guru.hb@oracle.com

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@arun-joseph
Contributor Guru HB <guru.hb@oracle.com> successfully added.

@arun-joseph
Copy link
Member Author

/contributor remove Bhawesh Choudhary bhawesh.choudhary@oracle.com

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@arun-joseph
Contributor Bhawesh Choudhary <bhawesh.choudhary@oracle.com> successfully removed.

@arun-joseph
Copy link
Member Author

/contributor remove Guru HB guru.hb@oracle.com

@arun-joseph
Copy link
Member Author

/contributor add ghb

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@arun-joseph
Contributor Guru HB <guru.hb@oracle.com> successfully removed.

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@arun-joseph
Contributor Guru Hb <ghb@openjdk.org> successfully added.

@arun-joseph
Copy link
Member Author

/contributor add bchoudhary

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@arun-joseph
Contributor Bhawesh Choudhary <bchoudhary@openjdk.org> successfully added.

kevinrushforth
kevinrushforth approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested on all three platforms.

@bhaweshkc
Copy link
Contributor

Checked with various websites on all three platform. Looks good.

tiainen
tiainen approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@tiainen tiainen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested building on all three platforms.

@openjdk
Copy link

openjdk bot commented Jul 16, 2020 •
edited

@arun-joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8245284: Update to 610.1 version of WebKit

Co-authored-by: Guru Hb <ghb@openjdk.org>
Co-authored-by: Bhawesh Choudhary <bchoudhary@openjdk.org>
Reviewed-by: kcr, bchoudhary, sykora
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 18 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 281f5c270da0892b67cf8c7c1e59e0d9ac921ec7.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 16, 2020
@arun-joseph
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jul 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jul 16, 2020
@openjdk
Copy link

openjdk bot commented Jul 16, 2020

@arun-joseph The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.

Pushed as commit 5e7e452.

@arun-joseph arun-joseph deleted the 8245284 branch July 16, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhaweshkc bhaweshkc bhaweshkc approved these changes

@tiainen tiainen tiainen approved these changes

@kevinrushforth kevinrushforth kevinrushforth approved these changes

@johanvos johanvos Awaiting requested review from johanvos

Assignees
No one assigned
Labels
integrated Pull request has been integrated
Milestone
No milestone
4 participants
@arun-joseph @kevinrushforth @bhaweshkc @tiainen