Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248365: Debug build crashes on Windows when playing media file #265

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Jul 11, 2020

According to information found for similar bugs filed against libffi, this is known issue with libffi. libffi modifies stack frames and it triggers stack frame run-time error checking. Fixed by disabling stack frame error checking in debug build. It was already off in release build.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248365: Debug build crashes on Windows when playing media file

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/265/head:pull/265
$ git checkout pull/265

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 11, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 11, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 11, 2020

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8248365: Debug build crashes on Windows when playing media file

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 82f66caa880ad8228a024aa83ea564c60bd49257.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 11, 2020
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Jul 13, 2020

/integrate

@openjdk openjdk bot closed this Jul 13, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2020

@sashamatveev
Pushed as commit 946590e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants