-
Notifications
You must be signed in to change notification settings - Fork 541
8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
Webrevs
|
kevinrushforth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks good. I left one minor comment on the test.
Btw, it looks like you are missing a space between 0.75" and margins in the PR title, which is why Skara is saying: Title mismatch between PR and JBS.
|
|
||
| Printer printer = Printer.getDefaultPrinter(); | ||
| if (printer == null) { | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Normally we would use assumeNotNull so the test is marked as skipped rather than passed.
|
@prrace This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
For a Media that had no defined size - eg a "custom" paper - the code was creating a mapping
that over-rode the NA_LETTER size. This might cause multiple problems but definitely meant that
we ended up with default margins.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/266/head:pull/266$ git checkout pull/266