Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins #266

Closed
wants to merge 2 commits into from

Conversation

@prrace
Copy link
Collaborator

@prrace prrace commented Jul 15, 2020

For a Media that had no defined size - eg a "custom" paper - the code was creating a mapping
that over-rode the NA_LETTER size. This might cause multiple problems but definitely meant that
we ended up with default margins.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/266/head:pull/266
$ git checkout pull/266

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 15, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 16, 2020

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Fix looks good. I left one minor comment on the test.

Btw, it looks like you are missing a space between 0.75" and margins in the PR title, which is why Skara is saying: Title mismatch between PR and JBS.


Printer printer = Printer.getDefaultPrinter();
if (printer == null) {
return;
Copy link
Member

@kevinrushforth kevinrushforth Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Normally we would use assumeNotNull so the test is marked as skipped rather than passed.

@prrace prrace changed the title 8248908: Printer.createPageLayout() returns 0.75"margins instead of hardware margins 8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins Jul 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2020

@prrace This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8248908: Printer.createPageLayout() returns 0.75" margins instead of hardware margins

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 5e7e452: 8245284: Update to 610.1 version of WebKit

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5e7e452c5660ec32d0cca5d4664dc7aa8a1ced92.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 16, 2020
@prrace
Copy link
Collaborator Author

@prrace prrace commented Jul 16, 2020

/integrate

@openjdk openjdk bot closed this Jul 16, 2020
@openjdk openjdk bot added integrated and removed ready labels Jul 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 16, 2020

@prrace The following commits have been pushed to master since your change was applied:

  • 5e7e452: 8245284: Update to 610.1 version of WebKit

Your commit was automatically rebased without conflicts.

Pushed as commit f056d24.

@openjdk openjdk bot removed the rfr label Jul 16, 2020
@prrace prrace deleted the margins branch Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants