Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
8230492: font-family not set in HTMLEditor if font name has a number in it #27
In the HTMLEditor, when positioning the caret in a text and trying to set a font-family that has a number in it is not working.
Issue: In CSSPropertyParser.cpp, concatenateFamilyName() function parses only identifiers. So, when a number is introduced in a font-name, it fails.
Fix: Pass the font-name as a string in HTMLEditorSkin.java by adding quotes.
A new font is added as a resource for the test. This font is same as modules/javafx.web/src/main/native/Tools/DumpRenderTree/fonts/WebKit Layout Tests 2.ttf
JDK-8230492: font-family not set in HTMLEditor if font name has a number in it
kevinrushforth left a comment
The fix and new test look good to me. I can confirm that the new test fails without the fix and passes with the fix.
I left one minor formatting comment that you can correct before you integrate.
Unless @Maxoudela has any concerns, I think this can go in with a single reviewer (or he may wish to be the second reviewer).
@arun-Joseph This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there have been 2 commits pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge
As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth) but any other Committer may sponsor as well.
Your commit was automatically rebased without conflicts.
Pushed as commit 286d1b5.
Mailing list message from Kevin Rushforth email@example.com
8230492: font-family not set in HTMLEditor if font name has a number in it
Reviewed-by: kcr, shadzic