Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249839: Cherry pick GTK WebKit 2.28.3 changes #271

Closed
wants to merge 1 commit into from

Conversation

arun-joseph
Copy link
Member

@arun-joseph arun-joseph commented Jul 23, 2020

Update to GTK WebKit 2.28.3
https://webkitgtk.org/2020/07/09/webkitgtk2.28.3-released.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Bhawesh Choudhary (bchoudhary - Author)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/271/head:pull/271
$ git checkout pull/271

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Jul 23, 2020
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2020

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 23, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@bhaweshkc
Copy link
Contributor

Tested on all three platform. Looks good.

@openjdk
Copy link

openjdk bot commented Jul 24, 2020

@arun-joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8249839: Cherry pick GTK WebKit 2.28.3 changes

Reviewed-by: kcr, bchoudhary
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

  • aae8b6b: Merge
  • 3cc29e3: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175%
  • 5f60ea5: 8248381: Create a daemon thread for MonocleTimer
  • 9260fd1: Merge
  • 2f4666a: 8248490: [macOS] Undecorated stage does not minimize

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate aae8b6b8638f0b5212558e9f64b57c3013ea721b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 24, 2020
@arun-joseph
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jul 24, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Jul 24, 2020
@openjdk
Copy link

openjdk bot commented Jul 24, 2020

@arun-joseph The following commits have been pushed to master since your change was applied:

  • aae8b6b: Merge
  • 3cc29e3: 8220484: JFXPanel renders a slanted image with a hidpi monitor scale of 125% or 175%
  • 5f60ea5: 8248381: Create a daemon thread for MonocleTimer
  • 9260fd1: Merge
  • 2f4666a: 8248490: [macOS] Undecorated stage does not minimize

Your commit was automatically rebased without conflicts.

Pushed as commit 926b5b6.

@arun-joseph arun-joseph deleted the 8249839 branch July 24, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants