8250238: Media fails to load libav 58 library when using modules from maven central

[kevinrushforth]

When running a JavaFX application using the JavaFX modules from maven central, the native libraries are packed into the jar file, and then unpacked as needed by the JavaFX runtime. This fails for libavplugin-ffmpeg-58.so, because the entry for the avplugin-ffmpeg-58 library is missing from the list of dependent libraries of jfxmedia in NativeMediaManager.java.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8250238: Media fails to load libav 58 library when using modules from maven central

Reviewers

• Alexander Matveev (almatvee - Reviewer)
• Joeri Sykora (sykora - Author)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/272/head:pull/272
$ git checkout pull/272

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[kevinrushforth]

NOTE: This is targeted to jfx15. As such I would like a second reviewer.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

@sashamatveev can you review?

@tiainen or @johanvos can one of you review as well?

[mlbridge]

Webrevs

• 00: Full (3617449)

[sashamatveev]

Looks good.

[johanvos]

This should indeed go into 15.

[tiainen]

I've tested on Ubuntu 20.04 and playing media files works again with this fix.

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250238: Media fails to load libav 58 library when using modules from maven central

Reviewed-by: almatvee, sykora

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

There are currently no new commits on the jfx15 branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 3cc29e38c58e2414c3e79c71e8e507b9fd919a8c.

➡️ To integrate this PR with the above commit message to the jfx15 branch, type /integrate in a new comment.

[kevinrushforth]

/integrate

[openjdk]

@kevinrushforth
Pushed as commit 6b00892.