Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250238: Media fails to load libav 58 library when using modules from maven central #272

Closed
wants to merge 1 commit into from

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 23, 2020

When running a JavaFX application using the JavaFX modules from maven central, the native libraries are packed into the jar file, and then unpacked as needed by the JavaFX runtime. This fails for libavplugin-ffmpeg-58.so, because the entry for the avplugin-ffmpeg-58 library is missing from the list of dependent libraries of jfxmedia in NativeMediaManager.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250238: Media fails to load libav 58 library when using modules from maven central

Reviewers

  • Alexander Matveev (almatvee - Reviewer)
  • Joeri Sykora (sykora - Author)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/272/head:pull/272
$ git checkout pull/272

@kevinrushforth kevinrushforth changed the base branch from master to jfx15 Jul 23, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 23, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 23, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 23, 2020

NOTE: This is targeted to jfx15. As such I would like a second reviewer.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 23, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Jul 23, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 23, 2020

@sashamatveev can you review?

@tiainen or @johanvos can one of you review as well?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 23, 2020

Webrevs

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Jul 23, 2020

Looks good.

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Jul 24, 2020

This should indeed go into 15.

Copy link
Collaborator

@tiainen tiainen left a comment

I've tested on Ubuntu 20.04 and playing media files works again with this fix.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 24, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250238: Media fails to load libav 58 library when using modules from maven central

Reviewed-by: almatvee, sykora
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the jfx15 branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 3cc29e38c58e2414c3e79c71e8e507b9fd919a8c.

➡️ To integrate this PR with the above commit message to the jfx15 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 24, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Jul 24, 2020

/integrate

@openjdk openjdk bot closed this Jul 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 24, 2020

@kevinrushforth
Pushed as commit 6b00892.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8250238-libav58 branch Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants