8246343: Fix mistakes in FX API docs

[nlisker]

Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional fixes in the vicinity.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8246343: Fix mistakes in FX API docs

Reviewers

• Kevin Rushforth (kcr - Reviewer)
• Ajit Ghaisas (aghaisas - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/274/head:pull/274
$ git checkout pull/274

[bridgekeeper]

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[nlisker]

/reviewers 2

[openjdk]

@nlisker
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[mlbridge]

Webrevs

• 04: Full - Incremental (c74c482)
• 03: Full - Incremental (7bb6ff1)
• 02: Full - Incremental (141e78f)
• 01: Full - Incremental (5c7d74e)
• 00: Full (2927161)

[kevinrushforth]

Just a couple quick comments for now. I'll review it next week.

[kevinrushforth]

As long as you are fixing this: an VBox --> a VBox

[mlbridge]

Mailing list message from Rony G. Flatscher on openjfx-dev:

On 26.07.2020 12:10, Nir Lisker wrote:

One of the changes reads (at <https://git.openjdk.java.net/jfx/pull/274/files>):

modules/javafx.fxml/src/main/docs/javafx/fxml/doc-files/introduction_to_fxml.html
<https://github.com//pull/274/files#diff-7057a6e3191138952057e494b1753773>

Viewed

@@ -720,7 +720,7 @@ <h4><a id="collections_and_property_handlers">Special handlers for
collections a

<p> Collections and object properties cannot be listen to using <span class="code">setOn<span
class="variable">Event</span>()</span> methods.

For these reason, special handler methods need to be used.

<span class="code">ObservableList</span>, <span class="code">ObservableMap</span> or <span
class="code">ObservableSet</span>

uses a special <span class="code">onChange</span> attribute that points to a handler method with
a <span class="code">ListChangeListener.Change</span>, <span
class="code">MapChangeListener.Change</span> or <span
class="code">SetChangeListener.Change</span> parameter, respectively.

</p>

<pre class="code">

&lt;VBox fx:controller="com.foo.MyController"

Does anyone have FXML examples where "onChange" for ObservableList, ObservableMap and ObservableSet?
get employed?

---rony

[kevinrushforth]

A few inline comments, but otherwise looks fine.

[mlbridge]

Mailing list message from Nir Lisker on openjfx-dev:

Hi Rony,

I think that this PR is not the place for this question since it only fixes
a typo there.

On Mon, Jul 27, 2020 at 4:12 PM Rony G. Flatscher <Rony.Flatscher at wu.ac.at>
wrote:

On 26.07.2020 12:10, Nir Lisker wrote:

Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some
additional fixes in the vicinity.
Nir Lisker has updated the pull request incrementally with one
additional commit since the last revision:

[openjdk]

@nlisker This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8246343: Fix mistakes in FX API docs

Reviewed-by: kcr, aghaisas

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the jfx15 branch:

• fc38ce6: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge jfx15 into your branch, and then specify the current head hash when integrating, like this: /integrate fc38ce64ecd104625273a1950fe0a2e9b4db1e56.

➡️ To integrate this PR with the above commit message to the jfx15 branch, type /integrate in a new comment.

[nlisker]

/integrate

[openjdk]

@nlisker The following commits have been pushed to jfx15 since your change was applied:

• fc38ce6: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

Your commit was automatically rebased without conflicts.

Pushed as commit 487854c.