Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors #275

Closed
wants to merge 3 commits into from

Conversation

@aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Jul 27, 2020

Issue : https://bugs.openjdk.java.net/browse/JDK-8249647
Fix : Added missing explicit no-arg constructors to classes in package javafx.beans.binding in module javafx.base.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

Reviewers

  • Nir Lisker (nlisker - Reviewer)
  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/275/head:pull/275
$ git checkout pull/275

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 27, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into jfx15 will be added to the body of your pull request.

Loading

@openjdk openjdk bot added the rfr label Jul 27, 2020
@kleopatra
Copy link
Collaborator

@kleopatra kleopatra commented Jul 27, 2020

The single sentence of the min doc should end with a period, iirc ;)

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 27, 2020

Webrevs

Loading

@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented Jul 27, 2020

The single sentence of the min doc should end with a period, iirc ;)

Thanks.
Yes, I missed out on it.. will fix soon.

Loading

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 27, 2020

/reviewers 2

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Loading

Copy link
Collaborator

@nlisker nlisker left a comment

Please use @code for all class names, like {@code StringBinding}.

Loading

@kevinrushforth kevinrushforth self-requested a review Jul 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2020

@aghaisas This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

Reviewed-by: nlisker, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the jfx15 branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 6b008925f196f2f2835f6bf056b7fcaeadb947ab.

➡️ To integrate this PR with the above commit message to the jfx15 branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 28, 2020
@aghaisas
Copy link
Collaborator Author

@aghaisas aghaisas commented Jul 28, 2020

/integrate

Loading

@openjdk openjdk bot closed this Jul 28, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2020

@aghaisas
Pushed as commit fc38ce6.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants