Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors #277

Conversation

@nlisker
Copy link
Collaborator

@nlisker nlisker commented Jul 30, 2020

This was missed the in Javadoc fixes for 15.

Added documentation for all the constructors, did a bit of formatting, and removed redundant comments.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors

Reviewers

  • Johan Vos (jvos - Reviewer)
  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/277/head:pull/277
$ git checkout pull/277

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 30, 2020

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into jfx15 will be added to the body of your pull request.

@nlisker nlisker marked this pull request as ready for review Jul 30, 2020
@openjdk openjdk bot added the rfr label Jul 30, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2020

@kevinrushforth kevinrushforth self-requested a review Jul 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2020

@nlisker This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors

Reviewed-by: jvos, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the jfx15 branch:

  • 487854c: 8246343: Fix mistakes in FX API docs
  • fc38ce6: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge jfx15 into your branch, and then specify the current head hash when integrating, like this: /integrate 487854cb512ca051a1691b5fe7df7d986334d437.

➡️ To integrate this PR with the above commit message to the jfx15 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 10, 2020
@nlisker
Copy link
Collaborator Author

@nlisker nlisker commented Aug 10, 2020

/integrate

@openjdk openjdk bot closed this Aug 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 10, 2020

@nlisker The following commits have been pushed to jfx15 since your change was applied:

  • 487854c: 8246343: Fix mistakes in FX API docs
  • fc38ce6: 8249647: Many classes in package javafx.beans.binding in module javafx.base have implicit no-arg constructors

Your commit was automatically rebased without conflicts.

Pushed as commit 7a8708b.

@nlisker nlisker deleted the nlisker:8250799_NumberStringConverter_and_its_subclasses_are_missing_documentation_for_all_their_constructors branch Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants