Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8202990: javafx webview css filter property with display scaling #279

Closed
wants to merge 6 commits into from
Closed
@@ -41,7 +41,6 @@
import test.util.Util;

import static javafx.concurrent.Worker.State.SUCCEEDED;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
@@ -86,11 +85,7 @@ private void assertColorEquals(String msg, Color expected, Color actual, double
}

private void assertColorNotEquals(String msg, Color notExpected, Color actual, double delta) {
double deltaRed = Math.abs(notExpected.getRed() - actual.getRed());
double deltaGreen = Math.abs(notExpected.getGreen() - actual.getGreen());
double deltaBlue = Math.abs(notExpected.getBlue() - actual.getBlue());
double deltaOpacity = Math.abs(notExpected.getOpacity() - actual.getOpacity());
if (deltaRed < delta && deltaGreen < delta && deltaBlue < delta && deltaOpacity < delta) {
if (testColorEquals(notExpected, actual, delta)) {
fail(msg + " not expected:" + colorToString(notExpected)
+ " but was:" + colorToString(actual));
}
ProTip! Use n and p to navigate between commits in a pull request.