Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251352: Many javafx.base classes have implicit no-arg constructors #282

Closed
wants to merge 1 commit into from

Conversation

@bhaweshkc
Copy link
Collaborator

@bhaweshkc bhaweshkc commented Aug 17, 2020

Added missing explicit no-arg constructors to classes in package javafx.beans.property, javafx.collections, javafx.util and javafx.util.converter in module javafx.base.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251352: Many javafx.base classes have implicit no-arg constructors

Reviewers

  • Nir Lisker (nlisker - Reviewer)
  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/282/head:pull/282
$ git checkout pull/282

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 17, 2020

👋 Welcome back bchoudhary! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 17, 2020

Webrevs

@nlisker
Copy link
Collaborator

@nlisker nlisker commented Aug 17, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2020

@nlisker
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@openjdk
Copy link

@openjdk openjdk bot commented Aug 17, 2020

@bhaweshkc This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8251352: Many javafx.base classes have implicit no-arg constructors

Reviewed-by: nlisker, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 2aed5ad3e57cd8aa9875965d17eeb76e09dae13c.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nlisker, @kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 17, 2020
@bhaweshkc
Copy link
Collaborator Author

@bhaweshkc bhaweshkc commented Aug 18, 2020

/integrate

@openjdk openjdk bot added the sponsor label Aug 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@bhaweshkc
Your change (at version 9d56412) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 18, 2020

/sponsor

@openjdk openjdk bot closed this Aug 18, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Aug 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 18, 2020

@kevinrushforth @bhaweshkc
Pushed as commit b25ffc7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants