Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251353: Many javafx scenegraph classes have implicit no-arg constructors #283

wants to merge 5 commits into from
@@ -42,13 +42,6 @@
abstract public class Selector {

* @deprecated This constructor was exposed erroneously and will be removed in the next version.
@Deprecated(since="16", forRemoval=true)
Selector() {

private static class UniversalSelector {

This comment has been minimized.


nlisker Aug 18, 2020

Is a public constructor suitable in this class? createSelector(String) is the factory. There are public abstract methods here, on the other hand, so I don't know what the design idea is. The class docs should be updated too to say how to use this class.

This comment has been minimized.


kevinrushforth Aug 19, 2020

This one does not look like it should be public. It seems quite by accident, since the only two classes that subclass Selector are in the same package and are constructed by factory methods (their constructors are package-scope).

This seems like a good candidate for removal (via the deprecate-for-removal, remove route).

private static final Selector INSTANCE =
new SimpleSelector("*", null, null, null);
@@ -43,13 +43,6 @@

public static StyleConverter<String, Shape> getInstance() { return INSTANCE; }

* @deprecated This constructor was exposed erroneously and will be removed in the next version. Use {@link #getInstance()} instead.
@Deprecated(since="16", forRemoval=true)
ShapeConverter() {

@Override public Shape convert(ParsedValue<String, Shape> value, Font font) {

Shape shape = super.getCachedValue(value);
ProTip! Use n and p to navigate between commits in a pull request.