8252107: Media pipeline initialization can crash if audio or video bin state change fails

[sashamatveev]

https://bugs.openjdk.java.net/browse/JDK-8252107

• Fixed by checking return value of audio/video bin state change and stopping pipeline initialization if error occurred.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252107: Media pipeline initialization can crash if audio or video bin state change fails

Reviewers

• Kevin Rushforth (kcr - Reviewer)
• Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/285/head:pull/285
$ git checkout pull/285

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (2cc4e1d)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

I built and tested it on Linux and it looks good. Have you done a build / test on Mac and Windows as well?

[kevinrushforth]

The PR title doesn't match the JBS title. Can you fix it?

[sashamatveev]

I built and tested it on Linux and it looks good. Have you done a build / test on Mac and Windows as well?

Yes, Mac and Windows was tested with all formats.

[sashamatveev]

The PR title doesn't match the JBS title. Can you fix it?

Fixed. It looks like github auto truncate long titles.

[kevinrushforth]

Fixed. It looks like github auto truncate long titles.

Thanks. Yes, GitHub does do that.

[arapte]

Built and tested on Linux.

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252107: Media pipeline initialization can crash if audio or video bin state change fails

Reviewed-by: kcr, arapte

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate eb9886ae0a961ec69aa3717c8d39f179dc2c620b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sashamatveev]

/integrate

[openjdk]

@sashamatveev
Pushed as commit c3fb321.