Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252107: Media pipeline initialization can crash if audio or video bin state change fails #285

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Aug 20, 2020

https://bugs.openjdk.java.net/browse/JDK-8252107

  • Fixed by checking return value of audio/video bin state change and stopping pipeline initialization if error occurred.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252107: Media pipeline initialization can crash if audio or video bin state change fails

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/285/head:pull/285
$ git checkout pull/285

… state change fails
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 20, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 20, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 20, 2020

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 20, 2020

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review Aug 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 20, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 20, 2020

I built and tested it on Linux and it looks good. Have you done a build / test on Mac and Windows as well?

@kevinrushforth kevinrushforth requested a review from arapte Aug 20, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 20, 2020

The PR title doesn't match the JBS title. Can you fix it?

@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Aug 21, 2020

I built and tested it on Linux and it looks good. Have you done a build / test on Mac and Windows as well?

Yes, Mac and Windows was tested with all formats.

@sashamatveev sashamatveev changed the title 8252107: Media pipeline initializtion can crash if audio or video bin… 8252107: Media pipeline initializtion can crash if audio or video bin state change fails Aug 21, 2020
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Aug 21, 2020

The PR title doesn't match the JBS title. Can you fix it?

Fixed. It looks like github auto truncate long titles.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 21, 2020

Fixed. It looks like github auto truncate long titles.

Thanks. Yes, GitHub does do that.

@kevinrushforth kevinrushforth changed the title 8252107: Media pipeline initializtion can crash if audio or video bin state change fails 8252107: Media pipeline initialization can crash if audio or video bin state change fails Aug 24, 2020
@arapte
arapte approved these changes Aug 24, 2020
Copy link
Member

@arapte arapte left a comment

Built and tested on Linux.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2020

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252107: Media pipeline initialization can crash if audio or video bin state change fails

Reviewed-by: kcr, arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate eb9886ae0a961ec69aa3717c8d39f179dc2c620b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 24, 2020
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Aug 24, 2020

/integrate

@openjdk openjdk bot closed this Aug 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2020

@sashamatveev
Pushed as commit c3fb321.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants