Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251555: Remove unused focusedWindow field in glass Window to avoid leak #286

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 22, 2020

This is a follow-up to JDK-8241840 that removes an unused static focusedWindow field and its associated getter and setter from the platform-independent glass Window class. This is entirely unused by any of the glass platforms. The Monocle platform keeps track of the focusedWindow attribute itself.

The existing test.javafx.stage.FocusedWindowNativeTest automated test, which was added as part of JDK-8241840, was failing fairly consistently on one of our test machines before this fix, and now passes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251555: Remove unused focusedWindow field in glass Window to avoid leak

Reviewers

  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/286/head:pull/286
$ git checkout pull/286

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 22, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 22, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 22, 2020

Webrevs

@kevinrushforth kevinrushforth requested a review from arapte Aug 24, 2020
@arapte
arapte approved these changes Aug 25, 2020
Copy link
Member

@arapte arapte left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8251555: Remove unused focusedWindow field in glass Window to avoid leak

Reviewed-by: arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • c3fb321: 8252107: Media pipeline initialization can crash if audio or video bin state change fails

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c3fb32100ee7743348ff2ebaf68d9157d566c9b6.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 25, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 25, 2020

/integrate

@openjdk openjdk bot closed this Aug 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • c3fb321: 8252107: Media pipeline initialization can crash if audio or video bin state change fails

Your commit was automatically rebased without conflicts.

Pushed as commit ddf8814.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8251555-focused-window branch Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants