Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252060: gstreamer fails to build with gcc 10 #287

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Aug 25, 2020

Fixed by defining GST_API as GST_EXPORT for gcc compiler as per Kevin proposed solution. On Windows we do not need to define GST_API, since we using .def file to export symbols.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/287/head:pull/287
$ git checkout pull/287

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 25, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 25, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2020

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252060: gstreamer fails to build with gcc 10

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • ddf8814: 8251555: Remove unused focusedWindow field in glass Window to avoid leak

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ddf8814e663c7a0ebc28bf7b27dd3727f7b5dc39.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 25, 2020
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Aug 25, 2020

/integrate

@openjdk openjdk bot closed this Aug 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2020

@sashamatveev The following commits have been pushed to master since your change was applied:

  • ddf8814: 8251555: Remove unused focusedWindow field in glass Window to avoid leak

Your commit was automatically rebased without conflicts.

Pushed as commit 7a4bd9b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants