Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251941: ListCell: visual artifact when items contain null values #288

Closed
wants to merge 1 commit into from

Conversation

kleopatra
Copy link
Collaborator

@kleopatra kleopatra commented Aug 25, 2020

The issue describes the makroscopic effect/s, namely content showing in cells that are off range.

The base reason is missing cleanup of the cell on transition from not-empty to empty when the old item is a null contained in the items. Fixed by changing the logic to cope with that special case. Added tests that fail before and pass after the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251941: ListCell: visual artifact when items contain null values

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/288/head:pull/288
$ git checkout pull/288

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2020

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 25, 2020
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2020

Webrevs

@aghaisas
Copy link
Collaborator

Looks OK.

@openjdk
Copy link

openjdk bot commented Aug 28, 2020

@kleopatra This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8251941: ListCell: visual artifact when items contain null values

Reviewed-by: aghaisas
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 23ad8f4: 8251353: Many javafx scenegraph classes have implicit no-arg constructors
  • 7a4bd9b: 8252060: gstreamer fails to build with gcc 10
  • ddf8814: 8251555: Remove unused focusedWindow field in glass Window to avoid leak

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 23ad8f40dede0c4797c3eec8c61f924e1d41a728.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 28, 2020
@kleopatra
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Aug 28, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated rfr Ready for review labels Aug 28, 2020
@openjdk
Copy link

openjdk bot commented Aug 28, 2020

@kleopatra The following commits have been pushed to master since your change was applied:

  • 23ad8f4: 8251353: Many javafx scenegraph classes have implicit no-arg constructors
  • 7a4bd9b: 8252060: gstreamer fails to build with gcc 10
  • ddf8814: 8251555: Remove unused focusedWindow field in glass Window to avoid leak

Your commit was automatically rebased without conflicts.

Pushed as commit c86bd35.

@kleopatra kleopatra deleted the bug-fix-8251941 branch September 10, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants