8251941: ListCell: visual artifact when items contain null values

[kleopatra]

The issue describes the makroscopic effect/s, namely content showing in cells that are off range.

The base reason is missing cleanup of the cell on transition from not-empty to empty when the old item is a null contained in the items. Fixed by changing the logic to cope with that special case. Added tests that fail before and pass after the fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8251941: ListCell: visual artifact when items contain null values

Reviewers

• Ajit Ghaisas (aghaisas - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/288/head:pull/288
$ git checkout pull/288

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (5142541)

[aghaisas]

Looks OK.

[openjdk]

@kleopatra This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8251941: ListCell: visual artifact when items contain null values

Reviewed-by: aghaisas

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

• 23ad8f4: 8251353: Many javafx scenegraph classes have implicit no-arg constructors
• 7a4bd9b: 8252060: gstreamer fails to build with gcc 10
• ddf8814: 8251555: Remove unused focusedWindow field in glass Window to avoid leak

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 23ad8f40dede0c4797c3eec8c61f924e1d41a728.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kleopatra]

/integrate

[openjdk]

@kleopatra The following commits have been pushed to master since your change was applied:

• 23ad8f4: 8251353: Many javafx scenegraph classes have implicit no-arg constructors
• 7a4bd9b: 8252060: gstreamer fails to build with gcc 10
• ddf8814: 8251555: Remove unused focusedWindow field in glass Window to avoid leak

Your commit was automatically rebased without conflicts.

Pushed as commit c86bd35.