Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252381: Cherry pick GTK WebKit 2.28.4 changes #289

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Aug 27, 2020

Update to GTK WebKit 2.28.4
https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Bhawesh Choudhary (bchoudhary - Author)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/289/head:pull/289
$ git checkout pull/289

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 27, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 27, 2020

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 27, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. Also, I tested on all three platforms.

@bhaweshkc
Copy link
Collaborator

@bhaweshkc bhaweshkc commented Aug 28, 2020

Verified with all three platform. Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@arun-Joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252381: Cherry pick GTK WebKit 2.28.4 changes

Reviewed-by: kcr, bchoudhary
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

  • c86bd35: 8251941: ListCell: visual artifact when items contain null values
  • 23ad8f4: 8251353: Many javafx scenegraph classes have implicit no-arg constructors
  • 7a4bd9b: 8252060: gstreamer fails to build with gcc 10
  • ddf8814: 8251555: Remove unused focusedWindow field in glass Window to avoid leak
  • c3fb321: 8252107: Media pipeline initialization can crash if audio or video bin state change fails

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c86bd35345da980c5bfacd5b0a6b5a283fe4be3a.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 28, 2020
@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Aug 28, 2020

/integrate

@openjdk openjdk bot closed this Aug 28, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@arun-Joseph The following commits have been pushed to master since your change was applied:

  • c86bd35: 8251941: ListCell: visual artifact when items contain null values
  • 23ad8f4: 8251353: Many javafx scenegraph classes have implicit no-arg constructors
  • 7a4bd9b: 8252060: gstreamer fails to build with gcc 10
  • ddf8814: 8251555: Remove unused focusedWindow field in glass Window to avoid leak
  • c3fb321: 8252107: Media pipeline initialization can crash if audio or video bin state change fails

Your commit was automatically rebased without conflicts.

Pushed as commit 88c0f97.

@arun-Joseph arun-Joseph deleted the arun-Joseph:8252381 branch Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants