Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252387: Deprecate for removal css Selector and ShapeConverter constructors #290

Closed
wants to merge 2 commits into from

Conversation

@bhaweshkc
Copy link
Collaborator

@bhaweshkc bhaweshkc commented Aug 28, 2020

Deprecate the public constructor of javafx.css.Selector as it should not be public due to only being extended by classes in same package.
Deprecate the public constructor of javafx.css.converter.ShapeConverter as its a singleton class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252387: Deprecate for removal css Selector and ShapeConverter constructors

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/290/head:pull/290
$ git checkout pull/290

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 28, 2020

👋 Welcome back bchoudhary! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 28, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 28, 2020

/csr

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 28, 2020

/reviewers 2

@openjdk openjdk bot added the csr label Aug 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@kevinrushforth this pull request will not be integrated until the CSR request JDK-8252462 for issue JDK-8252387 has been approved.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 28, 2020

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 28, 2020

Constrcutor for class javafx.css.Selector should not be public as it is only extended by classes in same package. it should be changed to package-private
Constrcutor for class javafx.css.converter.ShapeConverter should be private rather than public as its a singleton class.

This is the eventual goal (for JavaFX 17), but it isn't what this bug is addressing for JavaFX 16. Can you reword this to indicate that this bug is just deprecating the constructors for removal, and that we will file a follow-up bug to later change the access?

Copy link
Collaborator

@nlisker nlisker left a comment

Looks good. Added a single comment.

@bhaweshkc bhaweshkc requested review from nlisker and kevinrushforth Aug 28, 2020
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. Please update the CSR to reflect the change in the docs Selector.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2020

@bhaweshkc This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252387: Deprecate for removal css Selector and ShapeConverter constructors

Reviewed-by: nlisker, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 8e3616c: 8252062: WebKit build fails with recent VS 2019 compiler
  • 87ad57f: 8251858: Update to Xcode 11.3.1
  • 88c0f97: 8252381: Cherry pick GTK WebKit 2.28.4 changes
  • c86bd35: 8251941: ListCell: visual artifact when items contain null values

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 8e3616cf78fd866a20e169a08b0d6782060787eb.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nlisker, @kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 29, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 29, 2020

This should not have been marked as ready by the Skara bot. Looks like there is a bug in the processing of the /csr since the CSR is not yet approved.

@bhaweshkc please wait until the CSR is approved before integrating.

@nlisker
Copy link
Collaborator

@nlisker nlisker commented Aug 29, 2020

@kevinrushforth Why is the Skara bot saying this PR can be integrated if the CSR is not approved yet?

Also, in the main post under Reviewers, the links to the users lead to a 404.

Should I submit bugs for these?

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 29, 2020

Why is the Skara bot saying this PR can be integrated if the CSR is not approved yet?

Looks like we both noticed this at the same time.

Also, in the main post under Reviewers, the links to the users lead to a 404.

I hadn't noticed this before.

Should I submit bugs for these?

Yes, please.

@openjdk openjdk bot removed the csr label Sep 2, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 2, 2020

@bhaweshkc the CSR is approved. Go ahead and /integrate when ready.

@bhaweshkc
Copy link
Collaborator Author

@bhaweshkc bhaweshkc commented Sep 3, 2020

/integrate

@openjdk openjdk bot added the sponsor label Sep 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 3, 2020

@bhaweshkc
Your change (at version eb2f71b) is now ready to be sponsored by a Committer.

@nlisker
Copy link
Collaborator

@nlisker nlisker commented Sep 3, 2020

/sponsor

@openjdk openjdk bot closed this Sep 3, 2020
@openjdk openjdk bot added integrated and removed sponsor labels Sep 3, 2020
@openjdk openjdk bot removed ready rfr labels Sep 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 3, 2020

@nlisker @bhaweshkc The following commits have been pushed to master since your change was applied:

  • 8e3616c: 8252062: WebKit build fails with recent VS 2019 compiler
  • 87ad57f: 8251858: Update to Xcode 11.3.1
  • 88c0f97: 8252381: Cherry pick GTK WebKit 2.28.4 changes
  • c86bd35: 8251941: ListCell: visual artifact when items contain null values

Your commit was automatically rebased without conflicts.

Pushed as commit a5ecfb6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants