Skip to content

8252387: Deprecate for removal css Selector and ShapeConverter constructors #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhaweshkc wants to merge 2 commits into from
Closed

8252387: Deprecate for removal css Selector and ShapeConverter constructors #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4719ef1
8252387: Deprecate for removal css Selector and ShapeConverter constr…
bhaweshkc Aug 28, 2020
eb2f71b
Updated Selector class comments as per review
bhaweshkc Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/javafx.graphics/src/main/java/javafx/css/Selector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@
*/
abstract public class Selector {

/**
* @deprecated This constructor was exposed erroneously and will be removed in the next version. Use {@link #createSelector(String)} instead.
*/
@Deprecated(since="16", forRemoval=true)
public Selector() {
}

private static class UniversalSelector {
private static final Selector INSTANCE =
new SimpleSelector("*", null, null, null);
Expand Down
7 changes: 7 additions & 0 deletions modules/javafx.graphics/src/main/java/javafx/css/converter/ShapeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ public class ShapeConverter extends StyleConverter<String, Shape> {

public static StyleConverter<String, Shape> getInstance() { return INSTANCE; }

/**
* @deprecated This constructor was exposed erroneously and will be removed in the next version. Use {@link #getInstance()} instead.
*/
@Deprecated(since="16", forRemoval=true)
public ShapeConverter() {
}

@Override public Shape convert(ParsedValue<String, Shape> value, Font font) {

Shape shape = super.getCachedValue(value);
Expand Down