Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251858: Update to Xcode 11.3.1 #291

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Aug 28, 2020

This updates the compiler used to build JavaFX on macOS to Xcode 11.3.1 + MacOSX10.15 sdk, which matches the compiler used to build JDK 16.

As noted in the bug report, Xcode 11.3.1 needs macOS 10.14.4 (Mojave) or later to build, but the produced artifacts will be able to run on earlier versions of macOS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Johan Vos (jvos - Reviewer)
  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/291/head:pull/291
$ git checkout pull/291

@kevinrushforth kevinrushforth requested review from johanvos, tiainen and arapte Aug 28, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 28, 2020

/reviewers 2

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 28, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 28, 2020

Webrevs

@arapte
arapte approved these changes Aug 29, 2020
Copy link
Member

@arapte arapte left a comment

Build verified on Mojave 10.14.6

@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8251858: Update to Xcode 11.3.1

Reviewed-by: jvos, arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 88c0f97876e94dbd932848094b43c6305930b873.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 29, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Aug 29, 2020

/integrate

@openjdk openjdk bot closed this Aug 29, 2020
@openjdk openjdk bot added integrated and removed ready labels Aug 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2020

@kevinrushforth
Pushed as commit 87ad57f.

@openjdk openjdk bot removed the rfr label Aug 29, 2020
@kevinrushforth kevinrushforth deleted the kevinrushforth:8251858-xcode-11 branch Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants