Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec #292

Conversation

@nlisker
Copy link
Collaborator

@nlisker nlisker commented Aug 30, 2020

Moving implementation details about lazy evaluation and equality checking to @implSpec.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/292/head:pull/292
$ git checkout pull/292

@nlisker nlisker changed the title 8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpecInitial commit 8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec Aug 30, 2020
@nlisker nlisker marked this pull request as ready for review Aug 30, 2020
@nlisker
Copy link
Collaborator Author

@nlisker nlisker commented Aug 30, 2020

/csr

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 30, 2020

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 30, 2020

@nlisker has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@nlisker please create a CSR request and add link to it in JDK-8252546. This pull request cannot be integrated until the CSR request is approved.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 30, 2020

Webrevs

@nlisker
Copy link
Collaborator Author

@nlisker nlisker commented Aug 30, 2020

Once we settle on the docs I'll create the CSR.

@kevinrushforth kevinrushforth self-requested a review Sep 1, 2020
Copy link
Member

@kevinrushforth kevinrushforth left a comment

I left a couple suggestions below.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good with one minor comment. Go ahead and create the CSR once you make the requested update.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 12, 2020

@nlisker This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec

Reviewed-by: kcr, arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 8 commits pushed to the master branch:

  • 976a763: 8240499: Enforce whitespace checking for additional source files
  • d6dee34: 8252547: Correct transformations docs in Node
  • 0514116: 8246745: ListCell/Skin: misbehavior on switching skin
  • 7506554: Merge
  • 4b75750: 8252784: Create release notes for JavaFX 15 (#296)
  • 3cb3ca8: 8202990: javafx webview css filter property with display scaling
  • a5ecfb6: 8252387: Deprecate for removal css Selector and ShapeConverter constructors
  • 8e3616c: 8252062: WebKit build fails with recent VS 2019 compiler

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 976a763852c423dd96a1ca954f11957fcceb800d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 12, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 12, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Sep 12, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@openjdk openjdk bot removed the ready label Sep 12, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 12, 2020

I see that SKARA-548 is still an issue, and that the PR was marked ready without the CSR being approved.

@nlisker
Copy link
Collaborator Author

@nlisker nlisker commented Sep 12, 2020

Yeah I saw. The CSR has been submitted. I think that the bot isn't picking up on it even.

@arapte
arapte approved these changes Sep 15, 2020
@openjdk openjdk bot added the ready label Sep 15, 2020
@nlisker
Copy link
Collaborator Author

@nlisker nlisker commented Sep 15, 2020

It's not really ready to be integrated, right? It's not finding the CSR I think.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 15, 2020

Correct. It is not yet ready. SKARA-548 is not yet resolved, so shows as ready even though it isn't.

@openjdk openjdk bot removed the csr label Sep 15, 2020
@nlisker
Copy link
Collaborator Author

@nlisker nlisker commented Sep 16, 2020

The CSR has been approved, I'll go ahead and integrate.

@nlisker
Copy link
Collaborator Author

@nlisker nlisker commented Sep 16, 2020

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@nlisker Since your change was applied there have been 8 commits pushed to the master branch:

  • 976a763: 8240499: Enforce whitespace checking for additional source files
  • d6dee34: 8252547: Correct transformations docs in Node
  • 0514116: 8246745: ListCell/Skin: misbehavior on switching skin
  • 7506554: Merge
  • 4b75750: 8252784: Create release notes for JavaFX 15 (#296)
  • 3cb3ca8: 8202990: javafx webview css filter property with display scaling
  • a5ecfb6: 8252387: Deprecate for removal css Selector and ShapeConverter constructors
  • 8e3616c: 8252062: WebKit build fails with recent VS 2019 compiler

Your commit was automatically rebased without conflicts.

Pushed as commit b2e2000.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nlisker nlisker deleted the nlisker:8252546_Move_ObservableValue's_equality_check_and_lazy_evaluation_descriptions_to_@implSpec branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants