8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec

[nlisker]

Moving implementation details about lazy evaluation and equality checking to @implSpec.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/292/head:pull/292
$ git checkout pull/292

[nlisker]

/csr

[bridgekeeper]

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[openjdk]

@nlisker has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@nlisker please create a CSR request and add link to it in JDK-8252546. This pull request cannot be integrated until the CSR request is approved.

[mlbridge]

Webrevs

• 02: Full - Incremental (6529dc4)
• 01: Full - Incremental (2a0b1f3)
• 00: Full (808ba3c)

[nlisker]

Once we settle on the docs I'll create the CSR.

[kevinrushforth]

I left a couple suggestions below.

[kevinrushforth]

Looks good with one minor comment. Go ahead and create the CSR once you make the requested update.

[openjdk]

@nlisker This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252546: Move ObservableValue's equality check and lazy evaluation descriptions to @implSpec

Reviewed-by: kcr, arapte

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 8 commits pushed to the master branch:

• 976a763: 8240499: Enforce whitespace checking for additional source files
• d6dee34: 8252547: Correct transformations docs in Node
• 0514116: 8246745: ListCell/Skin: misbehavior on switching skin
• 7506554: Merge
• 4b75750: 8252784: Create release notes for JavaFX 15 (8252784: Create release notes for JavaFX 15 #296)
• 3cb3ca8: 8202990: javafx webview css filter property with display scaling
• a5ecfb6: 8252387: Deprecate for removal css Selector and ShapeConverter constructors
• 8e3616c: 8252062: WebKit build fails with recent VS 2019 compiler

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 976a763852c423dd96a1ca954f11957fcceb800d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

I see that SKARA-548 is still an issue, and that the PR was marked ready without the CSR being approved.

[nlisker]

Yeah I saw. The CSR has been submitted. I think that the bot isn't picking up on it even.

[nlisker]

It's not really ready to be integrated, right? It's not finding the CSR I think.

[kevinrushforth]

Correct. It is not yet ready. SKARA-548 is not yet resolved, so shows as ready even though it isn't.

[nlisker]

The CSR has been approved, I'll go ahead and integrate.

[nlisker]

/integrate

[openjdk]

@nlisker Since your change was applied there have been 8 commits pushed to the master branch:

• 976a763: 8240499: Enforce whitespace checking for additional source files
• d6dee34: 8252547: Correct transformations docs in Node
• 0514116: 8246745: ListCell/Skin: misbehavior on switching skin
• 7506554: Merge
• 4b75750: 8252784: Create release notes for JavaFX 15 (8252784: Create release notes for JavaFX 15 #296)
• 3cb3ca8: 8202990: javafx webview css filter property with display scaling
• a5ecfb6: 8252387: Deprecate for removal css Selector and ShapeConverter constructors
• 8e3616c: 8252062: WebKit build fails with recent VS 2019 compiler

Your commit was automatically rebased without conflicts.

Pushed as commit b2e2000.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.