8252062: WebKit build fails with recent VS 2019 compiler #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebKit build fails with recent VS 2019 compiler.
Bug: This MediaQueryEvaluator constructor takes a String parameter, but the conversion of char* to String is failing.
Fix: Use the default constructor of MediaQueryEvaluator, which also returns true for "all".
Test: Build webkit with the recent VS 2019 compiler with and without this fix. It should fail without the fix and build with the fix.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/294/head:pull/294
$ git checkout pull/294