Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252062: WebKit build fails with recent VS 2019 compiler #294

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Sep 2, 2020

The WebKit build fails with recent VS 2019 compiler.

Bug: This MediaQueryEvaluator constructor takes a String parameter, but the conversion of char* to String is failing.

Fix: Use the default constructor of MediaQueryEvaluator, which also returns true for "all".

Test: Build webkit with the recent VS 2019 compiler with and without this fix. It should fail without the fix and build with the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252062: WebKit build fails with recent VS 2019 compiler

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/294/head:pull/294
$ git checkout pull/294

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 2, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Sep 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 2, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 2, 2020

@arun-Joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252062: WebKit build fails with recent VS 2019 compiler

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 87ad57f: 8251858: Update to Xcode 11.3.1

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 87ad57f1e79d2781d2bf8c1fe147222a6c2332f1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 2, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 2, 2020

This is simple enough that a single reviewer will suffice.

@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Sep 2, 2020

/integrate

@openjdk openjdk bot closed this Sep 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 2, 2020

@arun-Joseph The following commits have been pushed to master since your change was applied:

  • 87ad57f: 8251858: Update to Xcode 11.3.1

Your commit was automatically rebased without conflicts.

Pushed as commit 8e3616c.

@arun-Joseph arun-Joseph deleted the arun-Joseph:8252062 branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants