Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors #30

Conversation

@nlisker
Copy link
Contributor

nlisker commented Nov 5, 2019

CSR: https://bugs.openjdk.java.net/browse/JDK-8233704

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

Approvers

  • Kevin Rushforth (kcr - Reviewer)
  • Ambarish Rapte (arapte - Reviewer)
Deprecate JavaBeanXxxPropertyBuilders public constructors
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2019

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Nov 5, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2019

Webrevs

@nlisker
Copy link
Contributor Author

nlisker commented Nov 5, 2019

jcheck failed several times before passing. The report said "Exception occurred during jcheck - the operation will be retried". If there is a log of the failures someone might want to have a look.

@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 6, 2019

jcheck failed several times before passing. The report said "Exception occurred during jcheck - the operation will be retried". If there is a log of the failures someone might want to have a look.

@rwestberg @edvbld can you take a look?

Copy link
Member

kevinrushforth left a comment

This looks fine with one (minor) formatting comment. Go ahead and create the CSR and I'll review that as well.

@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 6, 2019

I changed the bug summary to include for removal in the title. Can you change the PR title to match?

@rwestberg
Copy link
Member

rwestberg commented Nov 6, 2019

Thanks for the notification, looks like GitHub returned 500 for a few minutes. This seem to happen from time to time, so nice to know that the retry logic works. :)

@nlisker nlisker changed the title 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors Nov 6, 2019
@nlisker nlisker requested a review from kevinrushforth Nov 6, 2019
Copy link
Member

kevinrushforth left a comment

Looks good. This will need a second reviewer and an approved CSR before integration.

@openjdk openjdk bot removed the rfr label Nov 13, 2019
@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 13, 2019

@arapte can you also review this?

@openjdk
Copy link

openjdk bot commented Nov 13, 2019

@nlisker This change can now be integrated. The commit message will be:

8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

Reviewed-by: kcr, arapte
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 14 commits pushed to the master branch:

  • aad1720: 8233420: Upgrade to gcc 8.3 on Linux
  • 42040c4: 8232063: Upgrade gradle to version 6.0
  • aab07a4: 8234239: [TEST_BUG] Reenable few ignored web tests
  • 95ad601: 8233421: Upgrade to Visual Studio 2017 version 15.9.16
  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests
  • e37cb37: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest
  • 4f496d4: 8234194: [TEST_BUG] Reenable few graphics unit tests
  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests
  • dc01309: 8234110: SwingFXUtilsTest is unsuitable for unit test framework
  • 5b96ee4: 8231188: Update SQLite to version 3.30.1
  • d46dcae: 8233338: FX javadoc headings are out of sequence
  • 94bcf3f: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene
  • 286d1b5: 8230492: font-family not set in HTMLEditor if font name has a number in it

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Nov 13, 2019
Copy link

arapte left a comment

Please add @deprecated javadoc tag in the description for all constructors.

@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 18, 2019

Please add @deprecated javadoc tag in the description for all constructors.

Good idea.

@nlisker
Copy link
Contributor Author

nlisker commented Nov 19, 2019

Good suggestion. I will change to

/**
* @deprecated This constructor was exposed erroneously and will be removed in the next version. Use {@link #create()} instead.
*/
@Deprecated(since="14", forRemoval=true)

I noticed that the ReadOnlyJavaBeanXxxPropertyBuilders also have the same issue. Can I fix them in this PR too or do we need a new one?

Also, the CSR is finalized, can I change it at this point?

@kevinrushforth
Copy link
Member

kevinrushforth commented Nov 19, 2019

I noticed that the ReadOnlyJavaBeanXxxPropertyBuilders also have the same issue. Can I fix them in this PR too or do we need a new one?

Good catch. Not sure how we missed this before now (the change for JavaFX 13 also missed it), but yes, I'd prefer to fix this now for the ReadOnlyJavaBeanXxxPropertyBuilders, too.

For the CSR, you can move it back to Draft, edit it, and then once the review is done, Finalize it again (no need to go through the Proposed phase a second time).

@nlisker nlisker requested a review from kevinrushforth Nov 19, 2019
Copy link
Member

kevinrushforth left a comment

The updated version looks good. I checked the javadoc-generated API docs as well.

@arapte
arapte approved these changes Nov 20, 2019
Copy link

arapte left a comment

lgtm, verified the javadoc. DEPRECATED section has all the new constructors.

@nlisker
Copy link
Contributor Author

nlisker commented Nov 20, 2019

/integrate

@openjdk openjdk bot closed this Nov 20, 2019
@openjdk openjdk bot added integrated and removed ready labels Nov 20, 2019
@openjdk
Copy link

openjdk bot commented Nov 20, 2019

@nlisker The following commits have been pushed to master since your change was applied:

  • aad1720: 8233420: Upgrade to gcc 8.3 on Linux
  • 42040c4: 8232063: Upgrade gradle to version 6.0
  • aab07a4: 8234239: [TEST_BUG] Reenable few ignored web tests
  • 95ad601: 8233421: Upgrade to Visual Studio 2017 version 15.9.16
  • 3e0557a: 8234303: [TEST_BUG] Correct ignore tag in graphics unit tests
  • e37cb37: 8234150: Address ignored tests in ComboBoxTest, LabeledTest, HyperLinkTest and TextInputControlTest
  • 4f496d4: 8234194: [TEST_BUG] Reenable few graphics unit tests
  • 927fc8a: 8234174: Change IDEA VCS mapping to Git
  • 3d0cb49: 8234189: [TEST_BUG] Remove ignored and invalid graphics unit tests
  • dc01309: 8234110: SwingFXUtilsTest is unsuitable for unit test framework
  • 5b96ee4: 8231188: Update SQLite to version 3.30.1
  • d46dcae: 8233338: FX javadoc headings are out of sequence
  • 94bcf3f: 8231692: Test Infrastructure: enhance KeyEventFirer to inject keyEvents into scene
  • 286d1b5: 8230492: font-family not set in HTMLEditor if font name has a number in it

Your commit was automatically rebased without conflicts.

Pushed as commit 8bea7b7.

@mlbridge
Copy link

mlbridge bot commented Nov 20, 2019

Mailing list message from Nir Lisker on openjfx-dev:

Changeset: 8bea7b7
Author: Nir Lisker
Date: 2019-11-20 06:53:00 +0000
URL: https://git.openjdk.java.net/jfx/commit/8bea7b71

8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

Reviewed-by: kcr, arapte

! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanBooleanPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanDoublePropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanFloatPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanIntegerPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanLongPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanObjectPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanStringPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanBooleanPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanDoublePropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanFloatPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanIntegerPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanLongPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanObjectPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanStringPropertyBuilder.java

@nlisker nlisker deleted the nlisker:8229472_Deprecate_JavaBeanXxxPropertyBuilders_public_constructors branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.