-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8240499: Enforce whitespace checking for additional source files #301
8240499: Enforce whitespace checking for additional source files #301
Conversation
Part 1: update the .jcheck/conf file and checkWhiteSpace script
Part 2: Fix files as of 2020-09-11
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with before/after tests, and it works as expected.
@kevinrushforth This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@kevinrushforth Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 976a763. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The
.jcheck/conf
file is configured to check the same set of files as the old HG jcheck, namely files with the following extensions:The Skara git jcheck allows us to evolve the rules for white space checking compatibly.
This PR adds the following additional file extensions to the list of source files that need to be kept whitespace-clean:
For ease of review, I have done the initial push as 2 commits. The first modifies the
.jcheck/conf
file andtools/scripts/checkWhiteSpace
script to add the additional extensions. The second fixes the whitespace errors in the (39) files among those with the newly added extensions.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/301/head:pull/301
$ git checkout pull/301