8253634: TreeCell/Skin: misbehavior on switching skin

[kleopatra]

TreeCellSkin installs listeners to the TreeView/fixedCellSize that introduce a memory leak, NPE on replacing the treeView and incorrect update of internal state.

Fixed by removing the listeners (and the internal state had been copied from treeView on change) and access of listView state when needed.

Added tests that failed before and pass after the fix, plus a sanity test to guarantee same (correct) behavior before/after.

Issue and fix is basically the same as for ListCellSkin JDK-8246745

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253634: TreeCell/Skin: misbehavior on switching skin

Reviewers

• Ambarish Rapte (@arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/309/head:pull/309
$ git checkout pull/309

[bridgekeeper]

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (a3149fc)

[kevinrushforth]

@arapte I think a single reviewer should be sufficient, but if you think it needs a second reviewer, go ahead and indicate that.

[arapte]

As @kleopatra has already mentioned it that Issue and fix is basically the same as for ListCellSkin JDK-8246745.
It looks good...

[openjdk]

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253634: TreeCell/Skin: misbehavior on switching skin

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• 51c09e5: 8254691: Enable GitHub actions for jfx repo
• 1a11334: 8244297: Provide utility for testing for memory leaks
• 0376e60: 8255487: Mark SandboxAppTest unstable on Windows
• 7da928b: 8255497: [TestBug] Controls unit tests - clean up unnecessary prints on STANDARD_OUT
• 4f1eb7d: 8254013: gradle test should run all test classes even if they don't end with "Test"
• 690d266: 8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log ClassCastException
• 2c67555: 8213573: MouseLocationOnScreenTest fails intermittently
• 243b1a5: 8255241: [TestBug] Re-enable few ignored tests in javafx.controls module that pass with latest code
• 4e5f0e6: 8252596: [TESTBUG] WebPageShim::paint is not thread-safe
• a5a71d1: 8247494: Test failure in ImageRaceTest on some systems
• ... and 25 more: https://git.openjdk.java.net/jfx/compare/d10f948ee7380ac73bc4e2d5bff1caba50fe00a8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kleopatra]

/integrate

[openjdk]

@kleopatra Since your change was applied there have been 35 commits pushed to the master branch:

• 51c09e5: 8254691: Enable GitHub actions for jfx repo
• 1a11334: 8244297: Provide utility for testing for memory leaks
• 0376e60: 8255487: Mark SandboxAppTest unstable on Windows
• 7da928b: 8255497: [TestBug] Controls unit tests - clean up unnecessary prints on STANDARD_OUT
• 4f1eb7d: 8254013: gradle test should run all test classes even if they don't end with "Test"
• 690d266: 8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log ClassCastException
• 2c67555: 8213573: MouseLocationOnScreenTest fails intermittently
• 243b1a5: 8255241: [TestBug] Re-enable few ignored tests in javafx.controls module that pass with latest code
• 4e5f0e6: 8252596: [TESTBUG] WebPageShim::paint is not thread-safe
• a5a71d1: 8247494: Test failure in ImageRaceTest on some systems
• ... and 25 more: https://git.openjdk.java.net/jfx/compare/d10f948ee7380ac73bc4e2d5bff1caba50fe00a8...master

Your commit was automatically rebased without conflicts.

Pushed as commit cb545cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.