Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252191: Update to gcc 10.2 on Linux #311

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 29, 2020

This patch updates the compiler to gcc 10.2 on Linux, in order to match JDK 16 -- see JDK-8253616.

I ran a full build and test, including media and WebKit.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/311/head:pull/311
$ git checkout pull/311

@kevinrushforth kevinrushforth requested review from johanvos, tiainen and arapte Sep 29, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Sep 29, 2020

/reviewers 2

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2020

Webrevs

@kevinrushforth kevinrushforth self-assigned this Sep 29, 2020
@arapte
arapte approved these changes Oct 6, 2020
Copy link
Member

@arapte arapte left a comment

Build and sanity test looks good on my machine.

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Oct 6, 2020

Build and sanity test looks good on my machine.

What OS are you using? (I'm running a test on Ubuntu 18.04)

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Oct 6, 2020

I've run tests on Ubuntu 16.04, Ubuntu 20.04, and Oracle Linux 7.

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Oct 6, 2020

I confirm it works on Ubuntu 18.04

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8252191: Update to gcc 10.2 on Linux

Reviewed-by: arapte, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 15e52d8: 8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15
  • 5b42b64: 8252236: TabPane: must keep header of selected tab visible
  • 77a183e: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 6, 2020
@arapte
Copy link
Member

@arapte arapte commented Oct 6, 2020

What OS are you using? (I'm running a test on Ubuntu 18.04)

I also have 18.04.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Oct 6, 2020

/integrate

@openjdk openjdk bot closed this Oct 6, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@kevinrushforth Since your change was applied there have been 3 commits pushed to the master branch:

  • 15e52d8: 8253696: WebEngine refuses to load local "file:///" CSS stylesheets when using JDK 15
  • 5b42b64: 8252236: TabPane: must keep header of selected tab visible
  • 77a183e: 8209788: Left/Right/Ctrl+A keys not working in editor of ComboBox if popup showing

Your commit was automatically rebased without conflicts.

Pushed as commit 1c485a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8252191-gcc-10.2 branch Oct 7, 2020
@ebresie
Copy link

@ebresie ebresie commented Oct 8, 2020

Does the documentation need updating to reflect the change?

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Oct 8, 2020

The Wiki doesn't specify the version of gcc (it probably should, though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants