Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252192: Update to Visual Studio 2019 version 16.7.2 #312

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 29, 2020

This patch updates the compiler to Visual Studio 2019 version 16.7.2 on Windows, in order to match JDK 16 -- see JDK-8253615.

I ran a full build and test, including media and WebKit.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252192: Update to Visual Studio 2019 version 16.7.2

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jfx pull/312/head:pull/312
$ git checkout pull/312

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Sep 29, 2020

/reviewers 2

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2020

Webrevs

@arapte
arapte approved these changes Oct 6, 2020
Copy link
Member

@arapte arapte left a comment

Build and sanity test looks good on my machine(Edit: Win10).

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Oct 6, 2020

I just merged master in order to fix a trivial (and expected) merge conflict following the integration of the gcc 10.2 update.

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Oct 6, 2020

@tiainen can you build this on our farm?

@tiainen
Copy link
Collaborator

@tiainen tiainen commented Oct 6, 2020

Yes, I'll run a build against an updated Visual Studio 2019.

@tiainen
tiainen approved these changes Oct 6, 2020
Copy link
Collaborator

@tiainen tiainen left a comment

Build and sanity test completed successfully.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2020

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252192: Update to Visual Studio 2019 version 16.7.2

Reviewed-by: arapte, sykora, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7857022: 8251946: ObservableList.setAll does not conform to specification

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 6, 2020
@arapte
arapte approved these changes Oct 7, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Oct 7, 2020

/integrate

@openjdk openjdk bot closed this Oct 7, 2020
@openjdk openjdk bot added integrated and removed ready labels Oct 7, 2020
@openjdk openjdk bot removed the rfr label Oct 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 7, 2020

@kevinrushforth Since your change was applied there has been 1 commit pushed to the master branch:

  • 7857022: 8251946: ObservableList.setAll does not conform to specification

Your commit was automatically rebased without conflicts.

Pushed as commit 184f12c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8252192-vs2019-16.7.2 branch Oct 7, 2020
@ebresie
Copy link

@ebresie ebresie commented Oct 8, 2020

Does the documentation need updating to reflect the change?

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Oct 8, 2020

Not directly as a result of this PR, since we don't list the particular version of VS 2019 in our docs. However, it does remind me that the Building OpenJFX Wiki page needs updating -- it's out of date since it still mentions VS 2017. I'll fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants