New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252192: Update to Visual Studio 2019 version 16.7.2 #312
8252192: Update to Visual Studio 2019 version 16.7.2 #312
Conversation
/reviewers 2 |
|
@kevinrushforth |
Build and sanity test looks good on my machine(Edit: Win10).
I just merged |
@tiainen can you build this on our farm? |
Yes, I'll run a build against an updated Visual Studio 2019. |
@kevinrushforth This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@kevinrushforth Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 184f12c. |
Does the documentation need updating to reflect the change? |
Not directly as a result of this PR, since we don't list the particular version of VS 2019 in our docs. However, it does remind me that the Building OpenJFX Wiki page needs updating -- it's out of date since it still mentions VS 2017. I'll fix that. |
This patch updates the compiler to Visual Studio 2019 version 16.7.2 on Windows, in order to match JDK 16 -- see JDK-8253615.
I ran a full build and test, including media and WebKit.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/312/head:pull/312
$ git checkout pull/312